[jira] [Updated] (PIG-2681) TestDriverPig.countStores() does not correctly count the number of stores for pig scripts using variables for the alias

["Daniel Dai (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PIG-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-2681:
----------------------------
    Fix Version/s:     (was: 0.15.0)
                   0.16.0

> TestDriverPig.countStores() does not correctly count the number of stores for pig scripts using variables for the alias
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: PIG-2681
>                 URL: https://issues.apache.org/jira/browse/PIG-2681
>             Project: Pig
>          Issue Type: Test
>          Components: e2e harness
>    Affects Versions: 0.9.0, 0.9.1, 0.9.2, 0.10.0
>            Reporter: Araceli Henley
>             Fix For: 0.16.0
>
>         Attachments: PIG-2681.patch
>
>
> For  pig macros where the out parameter is referenced in a store statement, the TestDriveP.countStores() does not correctly count the number of stores:
> For example, the store will not be counted in :
> define myMacro(in1,in2) returns A {
>  A  = load '$in1' using PigStorage('$delimeter') as (intnum1000: int,id: int,intnum5: int,intnum100: int,intnum: int,longnum: long,floatnum: float,doublenum: double);
>    store $A into '$out';
> }
>  countStores() matches with:
>              $count += $q[$i] =~ /store\s+[a-zA-Z][a-zA-Z0-9_]*\s+into/i;
> Since the alias has a special character "$" it doesn't count it and the test fails.
> Need to change this to:
>    $count += $q[$i] =~ /store\s+(\$)?[a-zA-Z][a-zA-Z0-9_]*\s+into/i;
> I'll submit a patch shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)