You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/10 14:53:29 UTC

[GitHub] [flink] azagrebin opened a new pull request #9072: [FLINK-11630] Wait for the termination of all running Tasks when shutting down TaskExecutor

azagrebin opened a new pull request #9072: [FLINK-11630] Wait for the termination of all running Tasks when shutting down TaskExecutor
URL: https://github.com/apache/flink/pull/9072
 
 
   ## What is the purpose of the change
   
   Add a unit test to #8605.
   
   Currently, the `TaskExecutor` does not properly wait for the termination of Tasks when it shuts down in `TaskExecutor#onStop`. This patch changes `TaskExecutor#onStop` to fail all running tasks and wait  for their termination before stopping all services.
   
   ## Brief change log
   
     - add `TaskCompletionTracker` to track task termination futures in `TaskExecutor`
     - try to fail all running tasks and wait  for their termination before stopping all services
     - add `TaskExecutorTest.testTaskInterruptionAndTerminationOnShutdown`
   
   ## Verifying this change
   
   run `TaskExecutorTest.testTaskInterruptionAndTerminationOnShutdown`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services