[GitHub] [flink-kubernetes-operator] tweise commented on a change in pull request #38: [FLINK-26181] Support manual savepoint triggering in the operator

[GitBox <gi...@apache.org>]

tweise commented on a change in pull request #38:
URL: https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r819106604



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/JobReconciler.java
##########
@@ -109,6 +110,14 @@ public JobReconciler(
             }
         }
 
+        if (SavepointUtils.checkSavepointAnnotation(flinkApp)) {
+            triggerSavePoint(flinkApp, effectiveConfig);
+            SavepointUtils.removeSavepointAnnotation(flinkApp);

Review comment:
       What access does removing the annotation require? Are there situations where access is setup to prevent the operator from modifying the CR? (The operator is responsible for managing the status field, but not the CR.)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org