You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2017/01/28 16:21:03 UTC
[kudu-CR] KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV
Jordan Birdsell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5822
Change subject: KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV
......................................................................
KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV
The python client is currently crashing when a TableAlterer is directly
instantiated as opposed to instantiating via the new_table_alterer method
in the Client class. This patch addresses this issue and includes a new
unit test.
Change-Id: I074737c8f6992a7cd21f72f711337e915ffe2e82
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 24 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/5822/1
--
To view, visit http://gerrit.cloudera.org:8080/5822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I074737c8f6992a7cd21f72f711337e915ffe2e82
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
[kudu-CR] KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV
......................................................................
Patch Set 2: Verified+1
Test failure was the libboost issue that David's working on fixing.
--
To view, visit http://gerrit.cloudera.org:8080/5822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I074737c8f6992a7cd21f72f711337e915ffe2e82
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I074737c8f6992a7cd21f72f711337e915ffe2e82
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV
......................................................................
KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV
The python client is currently crashing when a TableAlterer is directly
instantiated as opposed to instantiating via the new_table_alterer method
in the Client class. This patch addresses this issue and includes a new
unit test.
Change-Id: I074737c8f6992a7cd21f72f711337e915ffe2e82
Reviewed-on: http://gerrit.cloudera.org:8080/5822
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 24 insertions(+), 5 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/5822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I074737c8f6992a7cd21f72f711337e915ffe2e82
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>