You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by xi...@apache.org on 2020/10/16 08:12:24 UTC

[shardingsphere] branch master updated: Add test case for database getSchema. (apache#7799) (#7805)

This is an automated email from the ASF dual-hosted git repository.

xiaoyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 4240e81  Add test case for database getSchema. (apache#7799) (#7805)
4240e81 is described below

commit 4240e81f0c9c6c2b86a2057064a54566d642f417
Author: liuyueve <39...@users.noreply.github.com>
AuthorDate: Fri Oct 16 16:11:59 2020 +0800

    Add test case for database getSchema. (apache#7799) (#7805)
---
 .../DatabaseMetaDataDialectHandlerTest.java        | 26 +++++++++++++++++-----
 1 file changed, 21 insertions(+), 5 deletions(-)

diff --git a/shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/model/physical/jdbc/handler/DatabaseMetaDataDialectHandlerTest.java b/shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/model/physical/jdbc/handler/DatabaseMetaDataDialectHandlerTest.java
index 117ff5c..969a927 100644
--- a/shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/model/physical/jdbc/handler/DatabaseMetaDataDialectHandlerTest.java
+++ b/shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/model/physical/jdbc/handler/DatabaseMetaDataDialectHandlerTest.java
@@ -55,12 +55,28 @@ public final class DatabaseMetaDataDialectHandlerTest {
     public void assertGetSchema() throws SQLException {
         when(connection.getMetaData()).thenReturn(databaseMetaData);
         when(databaseMetaData.getUserName()).thenReturn(USER_NAME);
-        String schema = getSchema(new OracleDatabaseType());
-        assertThat(schema, is(USER_NAME.toUpperCase()));
+
+        String oracleSchema = getSchema(new OracleDatabaseType());
+        assertThat(oracleSchema, is(USER_NAME.toUpperCase()));
+
         when(connection.getSchema()).thenReturn(USER_NAME);
-        String schemaMySQL = getSchema(new MySQLDatabaseType());
-        assertThat(schemaMySQL, is(USER_NAME));
-        // TODO H2, MariaDB, PostgreSQL, SQLServer, SQL92 database getSchema
+        String mysqlSchema = getSchema(new MySQLDatabaseType());
+        assertThat(mysqlSchema, is(USER_NAME));
+
+        String h2Schema = getSchema(new H2DatabaseType());
+        assertThat(h2Schema, is(USER_NAME));
+
+        String mariaDBSchema = getSchema(new MariaDBDatabaseType());
+        assertThat(mariaDBSchema, is(USER_NAME));
+
+        String postgreSQLSchema = getSchema(new PostgreSQLDatabaseType());
+        assertThat(postgreSQLSchema, is(USER_NAME));
+
+        String sqlServerSchema = getSchema(new SQLServerDatabaseType());
+        assertThat(sqlServerSchema, is(USER_NAME));
+
+        String sql92Schema = getSchema(new SQL92DatabaseType());
+        assertThat(sql92Schema, is(USER_NAME));
     }
     
     @Test