[GitHub] [tinkerpop] javeme edited a comment on issue #1222: TINKERPOP-1733 Support g.E().properties().hasKey('xx') & hasValue('xx')

[GitBox <gi...@apache.org>]

javeme edited a comment on issue #1222: TINKERPOP-1733 Support g.E().properties().hasKey('xx') & hasValue('xx')
URL: https://github.com/apache/tinkerpop/pull/1222#issuecomment-553719012
 
 
   > It seems there is no effect on HadoopProperty dedup:
   
   According to the implementation of [Property comparison](https://github.com/apache/tinkerpop/blob/be4defb541e9ce99712a53200dbe7794c63f06a3/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/ElementHelper.java#L485), in addition to comparing to the key and value, the parent element is also compared:
   ```java
   ElementHelper.areEqual(final Property a, final Object b) {
       return a.key().equals(((Property) b).key()) && a.value().equals(((Property) b).value()) && areEqual(a.element(), ((Property) b).element());
   }
   ```
   
   For [StarOutEdge and StarInEdge](https://github.com/apache/tinkerpop/blob/c2d7bd9c31b9d48f88017c1a077cb69437924d38/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/star/StarGraph.java#L818), the same edges with two directions are not equal.
   For [TinkerEdge](https://github.com/apache/tinkerpop/blob/cff4c161615f2b50bda27b6ba523c7f52b833532/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L41) the same edges with two directions are equal.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services