You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/10 18:58:28 UTC
[GitHub] [rocketmq-client-go] aireet opened a new pull request, #888: [feat] incr instanceCount in once and fmt codes
aireet opened a new pull request, #888:
URL: https://github.com/apache/rocketmq-client-go/pull/888
## What is the purpose of the change
i think we should incr instanceCount once, if we Start a consumer more than one times, instanceCount will increase one times, in the case, rmqClient.ShutDown will never work
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #888: [feat] incr instanceCount in once and fmt codes
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #888:
URL: https://github.com/apache/rocketmq-client-go/pull/888#issuecomment-1211144302
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/888?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#888](https://codecov.io/gh/apache/rocketmq-client-go/pull/888?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (693a6d1) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/ffd724165ee59b9108191b8fee72ec78f8535214?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ffd7241) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #888 +/- ##
=======================================
Coverage 25.28% 25.29%
=======================================
Files 51 51
Lines 6687 6686 -1
=======================================
Hits 1691 1691
Misses 4769 4769
+ Partials 227 226 -1
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/888?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [consumer/consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/888/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvY29uc3VtZXIuZ28=) | `17.68% <ø> (+0.03%)` | :arrow_up: |
| [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/888/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.17% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] yuz10 merged pull request #888: [feat] incr instanceCount in once and fmt codes
Posted by GitBox <gi...@apache.org>.
yuz10 merged PR #888:
URL: https://github.com/apache/rocketmq-client-go/pull/888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org