[GitHub] [incubator-doris] Gabriel39 commented on a diff in pull request #8967: [optimize](storage)optimize date in storage layer

[GitBox <gi...@apache.org>]

Gabriel39 commented on code in PR #8967:
URL: https://github.com/apache/incubator-doris/pull/8967#discussion_r897762753


##########
be/src/vec/columns/predicate_column.h:
##########
@@ -405,6 +435,9 @@ class PredicateColumnType final : public COWHelper<IColumn, PredicateColumnType<
         } else if constexpr (std::is_same_v<T, uint24_t>) {

Review Comment:
   could this code path be deleted?



##########
be/src/vec/runtime/vdatetime_value.h:
##########
@@ -223,6 +223,19 @@ class VecDateTimeValue { // Now this type is a temp solution with little changes
         return check_range_and_set_time(year, month, day, hour, minute, second, _type);
     }
 
+    //note(wb) not check in this method

Review Comment:
   why not use `from_olap_date` above instead?



##########
be/src/vec/runtime/vdatetime_value.h:
##########
@@ -223,6 +223,19 @@ class VecDateTimeValue { // Now this type is a temp solution with little changes
         return check_range_and_set_time(year, month, day, hour, minute, second, _type);
     }
 
+    //note(wb) not check in this method

Review Comment:
   And I'm not sure if it's reasonable to not check range here. Any ideas here?



##########
be/src/vec/columns/column_vector.h:
##########
@@ -169,17 +169,16 @@ class ColumnVector final : public COWHelper<ColumnVectorHelper, ColumnVector<T>>
     }
 
     void insert_date_column(const char* data_ptr, size_t num) {
-        size_t value_size = sizeof(uint24_t);
+        size_t input_value_size = sizeof(uint24_t);
+        
         for (int i = 0; i < num; i++) {

Review Comment:
   better to use pointer directly instead of `i`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org