You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/05/21 15:34:57 UTC
[Bug 122354] New: [sidebar] In slide sorter travers with arrow key
is one off in layout style
https://issues.apache.org/ooo/show_bug.cgi?id=122354
Bug ID: 122354
Issue Type: DEFECT
Summary: [sidebar] In slide sorter travers with arrow key is
one off in layout style
Classification: Application
Product: Impress
Version: AOO400-dev
Hardware: PC
OS: Windows 7
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: code
Assignee: issues@openoffice.apache.org
Reporter: rb.henschel@t-online.de
CC: issues@openoffice.apache.org
Blocks: 121420
Created attachment 80714
--> https://issues.apache.org/ooo/attachment.cgi?id=80714&action=edit
presentation with nine layouts applies
Open attached presentation. It has assigned layout 1 to slide 1, layout 2 to
slide 2, and so on.
Switch to slide sorter view.
Click one slide after the other with the mouse and watch that the assigned
layout is selected in the properties desk.
Now click with mouse on first slide and then traverse the slides using the
arrow right key. Notice, that the selected layout has an offset of 1. It does
not show the layout of the actual slide, but the layout of the previous slide.
Click on last slide with the mouse and then traverse back using the arrow left
key. Notice, that again the selected layout has an offset of 1.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122354] [sidebar] In slide sorter travers with arrow key is one
off in layout style
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122354
edoardopanfili <ed...@aspix.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |edoardo@aspix.it
--- Comment #4 from edoardopanfili <ed...@aspix.it> ---
tsted on
AOO400m2(Build:9701) - Rev. 1496831
2013-06-25 15:52:47 (Tue, 25 Jun 2013)
and on Win 8
AOO400m3(Build:9702) - Rev. 1499347
2013-07-03 15:11:47 (Mi, 03 Jul 2013)
works fine except one thing: slide 1 is not recognised as layout 1 ("blank
slide" ), "layout 2" is evidenced.
If I assign layout 1 then all works correctly.
I did a try with another presentation (do not works):
-create a new presentation: 3 slides: layout 1, layout 2, layout 3
-save and close
-open the presentation
-click on first slide: the layout evidenced is layout 2
another test (this one works)
-create a new presentation: 3 slides: layout 2, layout 1, layout 3
-save and close
-open the presentation
-click on second slide: the layout evidenced is layout 1 as expected
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 122354] [sidebar] In slide sorter travers with arrow key is one
off in layout style
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122354
hdu@apache.org <hd...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |AOO 4.0
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 122354] [sidebar] In slide sorter travers with arrow key is one
off in layout style
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122354
Andre <aw...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
CC| |awf.aoo@googlemail.com
Ever confirmed|0 |1
--- Comment #1 from Andre <aw...@googlemail.com> ---
When the current slide is changed via keys in the slide sorter view (as opposed
to the slide sorter bar) then the slide change is not broadcast properly. When
the current slide is changed via mouse then this works as expected.
Reason for this is lies in the way the slide change is notified:
- There are events for change in the slide sorter selection. The time at which
the modified selection is notified differs between keyboard and mouse
processing. For keyboard events the selection is broadcast before the current
slide is changed, for mouse event the broadcast takes place after the current
slide changed.
- The current slide is also set as property at the XController. However, the
slide sorter view has no real concept of a current slide and therefore the
"CurrentPage" property does not exist for the SdUnoSlideView sub controller.
The SdUnoDrawView does have this property, which is the reason why the bug is
only reproducible in the slide sorter view.
This can be fixed in two ways:
1. Add the "CurrentPage" property to the SdUnoSlideView sub controller. The
slide sorter keeps track of the current slide anyway, so that could be exposed
to the controller as well.
2. Notify the selection change of the slide sorter after the current slide has
been changed when the selection change is triggered by key events.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122354] [sidebar] In slide sorter travers with arrow key is one
off in layout style
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122354
--- Comment #3 from SVN Robot <sv...@dev.null.org> ---
"af" committed SVN revision 1485181 into trunk:
i122354: Fix notification of slide change when caused by slide sorter key
event.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 122354] [sidebar] In slide sorter travers with arrow key is one
off in layout style
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122354
--- Comment #5 from Andre <aw...@googlemail.com> ---
The remaining problems does not seem to have its origin in the layout panel of
the sidebar. I debugged setting and retrieving the layout value at/from the
page and everything looks as it should, except that after loading I see the
wrong layout value for slide 1 (when using document: "3 slides: layout 1,
layout 2, layout 3"). Maybe this goes wrong when the document is saved or
loaded.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 122354] [sidebar] In slide sorter travers with arrow key is one
off in layout style
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122354
Andre <aw...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|issues@openoffice.apache.or |awf.aoo@googlemail.com
|g |
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122354] [sidebar] In slide sorter travers with arrow key is one
off in layout style
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122354
Andre <aw...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Andre <aw...@googlemail.com> ---
Added a BroadcastLock to SelectionFunction::KeyInput() to prevent notification
of selection change while current slide is not yet updated. Processing of
mouse events already used a BroadcastLock and therefore did not have the
problem described above.
--
You are receiving this mail because:
You are on the CC list for the bug.