You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "Jens Geyer (Jira)" <ji...@apache.org> on 2026/05/27 21:26:00 UTC

[jira] [Closed] (THRIFT-1700) Number overflow in ReadFrame.

     [ https://issues.apache.org/jira/browse/THRIFT-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer closed THRIFT-1700.
------------------------------
    Resolution: Done

Fixed in netstd, older C# thrift library flavours are no longer supported.

> Number overflow in ReadFrame.
> -----------------------------
>
>                 Key: THRIFT-1700
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1700
>             Project: Thrift
>          Issue Type: Bug
>          Components: netstd - Library
>    Affects Versions: 0.8
>            Reporter: folex
>            Priority: Major
>
> private void ReadFrame()
> {
> 	byte[] i32rd = new byte[header_size];
> 	transport.ReadAll(i32rd, 0, header_size);
> 	int size =
> 		((i32rd[0] & 0xff) << 24) |
> 		((i32rd[1] & 0xff) << 16) |
> 		((i32rd[2] & 0xff) <<  8) |
> 		((i32rd[3] & 0xff));
> 	byte[] buff = new byte[size];
> 	transport.ReadAll(buff, 0, size);
> 	readBuffer = new MemoryStream(buff);
> }
> Here, when calculating size, number overflow throws sometimes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)