You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Xurenhe (Jira)" <ji...@apache.org> on 2021/09/02 12:03:00 UTC
[jira] [Comment Edited] (CALCITE-3935) Materialization-Failed,
meeting to pull up bottom filter of Left/Right Join
[ https://issues.apache.org/jira/browse/CALCITE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407258#comment-17407258 ]
Xurenhe edited comment on CALCITE-3935 at 9/2/21, 12:02 PM:
------------------------------------------------------------
[~yanlin-Lynn]
Please review this pr: https://github.com/apache/calcite/pull/2013
Thanks a lot.
was (Author: wojustme):
Please review this pr: https://github.com/apache/calcite/pull/2013
Thanks a lot.
> Materialization-Failed, meeting to pull up bottom filter of Left/Right Join
> ---------------------------------------------------------------------------
>
> Key: CALCITE-3935
> URL: https://issues.apache.org/jira/browse/CALCITE-3935
> Project: Calcite
> Issue Type: Bug
> Reporter: Xurenhe
> Priority: Major
> Labels: pull-request-available
> Attachments: Jietu20200417-200532.png
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Hi all.
> `SubstitutionVisitor` support more join_type in some rules of `Join`.
> Now `SubstitutionVisitor` only support join type of `INNER`, when pulling up bottom filters of join.
> It doesn't work as follows.
> {code:java}
> @Test public void testJoinOnLeftProjectWithFilterToJoin() {
> String mv = ""
> + "select \"emps\".\"empid\", \"depts\".\"name\", \"emps\".\"salary\"\n" +
> "from \"emps\"\n" +
> "left join \"depts\"\n" +
> "on \"emps\".\"deptno\" = \"depts\".\"deptno\"\n"
> + "where \"emps\".\"empid\" > 10";
> String query = ""
> + "select \"emps\".\"empid\", \"depts\".\"name\", \"emps\".\"salary\"\n" +
> "from \"emps\"\n" +
> "left join \"depts\"\n" +
> "on \"emps\".\"deptno\" = \"depts\".\"deptno\"\n"
> + "where \"emps\".\"empid\" > 40";
> sql(mv, query).withOnlyBySubstitution(true).ok();
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)