You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/25 12:13:46 UTC
[GitHub] [pulsar] Haaroon opened a new pull request #12978: Add guide to copy file source connector to container
Haaroon opened a new pull request #12978:
URL: https://github.com/apache/pulsar/pull/12978
Added instruction to copy file source connector into docker image.
Adjusted numbers accordingly
### Motivation
* I am testing out the file source connector and it would not run without this command
### Modifications
I have adjusted the guide to tell the user to copy the connector to the docker instance
### Verifying this change
This change is already covered by existing tests
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API: no
- The schema: no
- The default values of configurations: no
- The wire protocol: no
- The rest endpoints: no
- The admin cli options: no
- Anything that affects deployment: no
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [x] `doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #12978: Add guide to copy file source connector to container
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #12978:
URL: https://github.com/apache/pulsar/pull/12978#discussion_r760953013
##########
File path: site2/docs/io-file-source.md
##########
@@ -105,25 +105,32 @@ Here is an example of using the File source connecter.
$ curl -O https://mirrors.tuna.tsinghua.edu.cn/apache/pulsar/pulsar-{version}/connectors/pulsar-io-file-{version}.nar
```
-6. Start the File source connector.
+6. Copy it to the `connectors` folder, then restart the container
Review comment:
```suggestion
6. Copy it to the `connectors` folder, then restart the container.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Haaroon commented on pull request #12978: Add guide to copy file source connector to container
Posted by GitBox <gi...@apache.org>.
Haaroon commented on pull request #12978:
URL: https://github.com/apache/pulsar/pull/12978#issuecomment-984522204
all requested changes have been commited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #12978: Add guide to copy file source connector to container
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #12978:
URL: https://github.com/apache/pulsar/pull/12978#discussion_r760914308
##########
File path: site2/docs/io-file-source.md
##########
@@ -105,7 +105,13 @@ Here is an example of using the File source connecter.
$ curl -O https://mirrors.tuna.tsinghua.edu.cn/apache/pulsar/pulsar-{version}/connectors/pulsar-io-file-{version}.nar
```
-6. Start the File source connector.
+6. Copy the File source connector to the container.
+
+ ```bash
+ $ docker cp pulsar-io-file-{version}.nar pulsar-standalone:/pulsar/
Review comment:
Hi @Haaroon any feedback?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #12978: Add guide to copy file source connector to container
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #12978:
URL: https://github.com/apache/pulsar/pull/12978#discussion_r757176645
##########
File path: site2/docs/io-file-source.md
##########
@@ -105,7 +105,13 @@ Here is an example of using the File source connecter.
$ curl -O https://mirrors.tuna.tsinghua.edu.cn/apache/pulsar/pulsar-{version}/connectors/pulsar-io-file-{version}.nar
```
-6. Start the File source connector.
+6. Copy the File source connector to the container.
+
+ ```bash
+ $ docker cp pulsar-io-file-{version}.nar pulsar-standalone:/pulsar/
+ ```
+
+7. Start the File source connector.
Review comment:
@tuteng can you help this from a technical perspective? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Haaroon commented on pull request #12978: Add guide to copy file source connector to container
Posted by GitBox <gi...@apache.org>.
Haaroon commented on pull request #12978:
URL: https://github.com/apache/pulsar/pull/12978#issuecomment-984466995
Perfect, i have added the suggestions, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tuteng commented on a change in pull request #12978: Add guide to copy file source connector to container
Posted by GitBox <gi...@apache.org>.
tuteng commented on a change in pull request #12978:
URL: https://github.com/apache/pulsar/pull/12978#discussion_r757192715
##########
File path: site2/docs/io-file-source.md
##########
@@ -105,7 +105,13 @@ Here is an example of using the File source connecter.
$ curl -O https://mirrors.tuna.tsinghua.edu.cn/apache/pulsar/pulsar-{version}/connectors/pulsar-io-file-{version}.nar
```
-6. Start the File source connector.
+6. Copy the File source connector to the container.
+
+ ```bash
+ $ docker cp pulsar-io-file-{version}.nar pulsar-standalone:/pulsar/
Review comment:
Copy it to the `connectors` folder, then restart the container
```
docker cp pulsar-io-file-{version}.nar pulsar-standalone:/pulsar/connectors/
docker restart pulsar-standalone
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Haaroon edited a comment on pull request #12978: Add guide to copy file source connector to container
Posted by GitBox <gi...@apache.org>.
Haaroon edited a comment on pull request #12978:
URL: https://github.com/apache/pulsar/pull/12978#issuecomment-984466995
Perfect, i have added the suggestions, thank you. its ready to be merged at your discretion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #12978: Add guide to copy file source connector to container
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #12978:
URL: https://github.com/apache/pulsar/pull/12978#discussion_r760952633
##########
File path: site2/docs/io-file-source.md
##########
@@ -105,7 +105,13 @@ Here is an example of using the File source connecter.
$ curl -O https://mirrors.tuna.tsinghua.edu.cn/apache/pulsar/pulsar-{version}/connectors/pulsar-io-file-{version}.nar
```
-6. Start the File source connector.
+6. Copy the File source connector to the container.
+
+ ```bash
+ $ docker cp pulsar-io-file-{version}.nar pulsar-standalone:/pulsar/
Review comment:
Hi @tuteng, @Haaroon has incorporated your comment, any other technical comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #12978: Add guide to copy file source connector to container
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #12978:
URL: https://github.com/apache/pulsar/pull/12978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org