You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org> on 2006/02/21 04:39:24 UTC

[jira] Created: (GERONIMO-1642) Deployment plan namespace validation

Deployment plan namespace validation
------------------------------------

         Key: GERONIMO-1642
         URL: http://issues.apache.org/jira/browse/GERONIMO-1642
     Project: Geronimo
        Type: Improvement
  Components: web, deployment, OpenEJB  
    Versions: 1.0    
    Reporter: Aaron Mulder
     Fix For: 1.1


When you deploy with a geronimo deployment plan packaged in the archive, but it has the wrong namespace, the file is ignored.  If anything, you get a message saying the plan is required, or that the archive is not a WAR/JAR/etc.  We should have special detection for geronimo-application.xml, geronimo-ra.xml, geronimo-web.xml, and openejb-jar.xml that notices if the file is present but has the wrong namespace, and prints a suggestive WARN or ERROR message to the console.  Probably for the application.xml, web.xml, ra.xml, and ejb-jar.xml too.

People have asked for help on the mailing list several times recently when they had this (bad namespace) problem.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-1642) Deployment plan namespace validation

Posted by "Rakesh Midha (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1642?page=all ]

Rakesh Midha updated GERONIMO-1642:
-----------------------------------

    Attachment: namespace1642.patch


I tried this and found following results
-------------------------------------------------------------
for geronimo-web.xml
------------------------------
It gives Error: Unable to distribute myphonebook-web.war: Cannot handle web
plan with namespace http://geronimo.apache.org/xml/ns/j2ee/web-1.21
-- expecting http://geronimo.apache.org/xml/ns/j2ee/web-1.2 or
http://geronimo.apache.org/xml/ns/j2ee/web/tomcat-1.2

I think it was fixed in revision 406804

for geronimo-ra.xml
-----------------------------
It gives error: The document is not a
    connector@http://geronimo.apache.org/xml/ns/j2ee/connector-1.2:
    document element namespace mismatch expected
    "http://geronimo.apache.org/xml/ns/j2ee/connector-1.2" got
    "http://geronimo.apache.org/xml/ns/j2ee/connector-1.1a"

Again it is fixed

geronimo-application.xml, openejb-jar.xml and application-client
------------------------------------------------------------------------------------------
It is a problem mentioned in JIRA

-----------------------------------------------------------------------------------------------------------
-----------------------------------------------------------------------------------------------------------
The attached patch tries to fix it in generic way using SchemaConversionUtils.java

It tries to check for wrong element or namespace and instead of returning null, it throws XmlException with message 
Cannot find desiredElement "application" with
    namespace{http://geronimo.apache.org/xml/ns/j2ee/application-1.2} in
    the plan provided.

So after applying patch, geronimo-application.xml, openejb-jar.xml and application-client
gives required error msg -->
Cannot find desiredElement "application" with
    namespace{http://geronimo.apache.org/xml/ns/j2ee/application-1.2} in
    the plan provided.

I hope this is what is desired.

Thanks

> Deployment plan namespace validation
> ------------------------------------
>
>                 Key: GERONIMO-1642
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-1642
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: deployment, OpenEJB, web
>    Affects Versions: 1.1
>            Reporter: Aaron Mulder
>         Assigned To: Rakesh Midha
>            Priority: Critical
>             Fix For: 1.1.x
>
>         Attachments: namespace1642.patch
>
>
> When you deploy with a geronimo deployment plan packaged in the archive, but it has the wrong namespace, the file is ignored.  If anything, you get a message saying the plan is required, or that the archive is not a WAR/JAR/etc.  We should have special detection for geronimo-application.xml, geronimo-ra.xml, geronimo-web.xml, and openejb-jar.xml that notices if the file is present but has the wrong namespace, and prints a suggestive WARN or ERROR message to the console.  Probably for the application.xml, web.xml, ra.xml, and ejb-jar.xml too.
> People have asked for help on the mailing list several times recently when they had this (bad namespace) problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (GERONIMO-1642) Deployment plan namespace validation

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods updated GERONIMO-1642:
-----------------------------------

    Fix Version/s:     (was: 2.0-M5)
                   2.0-M6
         Assignee: Donald Woods

> Deployment plan namespace validation
> ------------------------------------
>
>                 Key: GERONIMO-1642
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-1642
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: deployment, OpenEJB, web
>    Affects Versions: 1.1
>            Reporter: Aaron Mulder
>         Assigned To: Donald Woods
>            Priority: Critical
>             Fix For: 2.0-M6
>
>         Attachments: namespace1642.patch
>
>
> When you deploy with a geronimo deployment plan packaged in the archive, but it has the wrong namespace, the file is ignored.  If anything, you get a message saying the plan is required, or that the archive is not a WAR/JAR/etc.  We should have special detection for geronimo-application.xml, geronimo-ra.xml, geronimo-web.xml, and openejb-jar.xml that notices if the file is present but has the wrong namespace, and prints a suggestive WARN or ERROR message to the console.  Probably for the application.xml, web.xml, ra.xml, and ejb-jar.xml too.
> People have asked for help on the mailing list several times recently when they had this (bad namespace) problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-1642) Deployment plan namespace validation

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496412 ] 

Donald Woods commented on GERONIMO-1642:
----------------------------------------

Hmmmm - this patch is causing a build time failure in client-security.  Will have to look into it more before committing....

[INFO] -------------------------------------------------------------------------
---
[INFO] Building Geronimo Configs :: J2EE Client Security
[INFO]    task-segment: [install]
[INFO] -------------------------------------------------------------------------
---
[INFO] [enforcer:enforce {execution: default}]
[INFO] [tools:copy-legal-files {execution: install-legal-files}]
[INFO] Created dir: E:\g20\g20\configs\client-security\target\classes\META-INF
[INFO] Copying 2 files to E:\g20\g20\configs\client-security\target\classes\META
-INF
[INFO] [resources:resources]
[INFO] Using default encoding to copy filtered resources.
[INFO] [car:prepare-plan]
[INFO] Generated: E:\g20\g20\configs\client-security\target\plan\plan.xml
[INFO] [car:package]
[INFO] Packaging module configuration: E:\g20\g20\configs\client-security\target
\plan\plan.xml
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] org.apache.xmlbeans.XmlException: Cannot find desiredElement "application" with namespace={http://geronimo.apache.org/xml/ns/j2ee/application-1.2} in plan=
<!--Licensed to the Apache Software Foundation (ASF) under one or more
    contributor license agreements.  See the NOTICE file distributed with
    this work for additional information regarding copyright ownership.
    The ASF licenses this file to You under the Apache License, Version 2.0
    (the "License"); you may not use this file except in compliance with
    the License.  You may obtain a copy of the License at
       http://www.apache.org/licenses/LICENSE-2.0
    Unless required by applicable law or agreed to in writing, software
    distributed under the License is distributed on an "AS IS" BASIS,
    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    See the License for the specific language governing permissions and
    limitations under the License.-->
<!--$Rev: 480572 $ $Date: 2006-11-29 09:01:50 -0500 (Wed, 29 Nov 2006) $-->
<module xmlns="http://geronimo.apache.org/xml/ns/deployment-1.2">
  <!--required-->
  <environment>
    <moduleId>
      <groupId>org.apache.geronimo.configs</groupId>
      <artifactId>client-security</artifactId>
      <version>2.0-SNAPSHOT</version>
      <type>car</type>
    </moduleId>
    <dependencies>
      <dependency>
        <groupId>org.apache.geronimo.configs</groupId>
        <artifactId>client</artifactId>
        <type>car</type>
      </dependency>
      <dependency>
        <groupId>org.apache.geronimo.modules</groupId>
        <artifactId>geronimo-security</artifactId>
        <version>2.0-SNAPSHOT</version>
        <type>jar</type>
        <import>classes</import>
      </dependency>
    </dependencies>
    <hidden-classes/>
    <non-overridable-classes/>
  </environment>
  <gbean name="SecurityService" class="org.apache.geronimo.security.SecurityServ
iceImpl">
    <reference name="ServerInfo">
      <name>ServerInfo</name>
    </reference>
    <attribute name="policyConfigurationFactory">org.apache.geronimo.security.ja
cc.GeronimoPolicyConfigurationFactory</attribute>
    <attribute name="policyProvider">org.apache.geronimo.security.jacc.GeronimoP
olicy</attribute>
    <attribute name="keyStore">var/security/clientcert.jks</attribute>
    <attribute name="keyStorePassword">changeit</attribute>
    <attribute name="trustStore">var/security/clientcert.jks</attribute>
    <attribute name="trustStorePassword">changeit</attribute>
  </gbean>
  <!--required-->
  <gbean name="LoginConfiguration" class="org.apache.geronimo.security.jaas.Gero
nimoLoginConfiguration">
    <references name="Configurations">
      <pattern>
        <type>SecurityRealm</type>
      </pattern>
      <pattern>
        <type>ConfigurationEntry</type>
      </pattern>
    </references>
  </gbean>
  <!--use for app client: logs into server remotely-->
  <gbean name="ServerLoginStubDCE" class="org.apache.geronimo.security.jaas.Dire
ctConfigurationEntry">
    <attribute name="applicationConfigName">server-login</attribute>
    <attribute name="controlFlag">REQUIRED</attribute>
    <reference name="Module">
      <name>ServerLoginCoordinator</name>
    </reference>
  </gbean>
  <gbean name="ServerLoginCoordinator" class="org.apache.geronimo.security.jaas.
LoginModuleGBean">
    <attribute name="loginModuleClass">org.apache.geronimo.security.jaas.client.
JaasLoginCoordinator</attribute>
    <attribute name="serverSide">false</attribute>
    <attribute name="options">host=localhost
            port=4242
            realm=geronimo-admin</attribute>
    <attribute name="loginDomainName">geronimo-admin</attribute>
  </gbean>
  <!--useful for corba: logs into a local realm, and server must reauthenticate
each call-->
  <gbean name="client-properties-realm" class="org.apache.geronimo.security.real
m.GenericSecurityRealm">
    <attribute name="realmName">client-properties-realm</attribute>
    <xml-reference name="LoginModuleConfiguration">
      <lc:login-config xmlns:lc="http://geronimo.apache.org/xml/ns/loginconfig-1
.2">
        <lc:login-module control-flag="REQUIRED" server-side="true" wrap-princip
als="true">
          <lc:login-domain-name>client-properties-realm</lc:login-domain-name>
          <lc:login-module-class>org.apache.geronimo.security.realm.providers.Pr
opertiesFileLoginModule</lc:login-module-class>
          <lc:option name="usersURI">var/security/users.properties</lc:option>
          <lc:option name="groupsURI">var/security/groups.properties</lc:option>

        </lc:login-module>
        <lc:login-module control-flag="REQUIRED" server-side="true" wrap-princip
als="true">
          <lc:login-domain-name>default</lc:login-domain-name>
          <lc:login-module-class>org.apache.geronimo.security.jaas.NamedUPCreden
tialLoginModule</lc:login-module-class>
          <lc:option name="org.apache.geronimo.jaas.NamedUPCredentialLoginModule
.Name">default</lc:option>
        </lc:login-module>
      </lc:login-config>
    </xml-reference>
    <reference name="ServerInfo">
      <name>ServerInfo</name>
    </reference>
    <reference name="LoginService">
      <name>JaasLoginService</name>
    </reference>
  </gbean>
  <!--this is really a server-side only gbean but its needed to make the client
side GenericSecurityRealm work-->
  <gbean name="JaasLoginService" class="org.apache.geronimo.security.jaas.server
.JaasLoginService">
    <reference name="Realms">
      <name>client-properties-realm</name>
    </reference>
    <!--<attribute name="reclaimPeriod">100000</attribute>-->
    <attribute name="algorithm">HmacSHA1</attribute>
    <attribute name="password">secret</attribute>
  </gbean>
  <gbean name="KeystoreManager" class="org.apache.geronimo.security.keystore.Fil
eKeystoreManager">
    <attribute name="keystoreDir">var/security/keystores</attribute>
    <reference name="ServerInfo">
      <name>ServerInfo</name>
    </reference>
    <references name="KeystoreInstances">
      <pattern>
        <type>Keystore</type>
      </pattern>
    </references>
  </gbean>
  <gbean name="geronimo-default" class="org.apache.geronimo.security.keystore.Fi
leKeystoreInstance">
    <attribute name="keystoreName">geronimo-default</attribute>
    <attribute name="keystorePath">var/security/keystores/geronimo-default</attr
ibute>
    <attribute name="keystorePassword">secret</attribute>
    <attribute name="keyPasswords">geronimo=secret</attribute>
    <reference name="ServerInfo">
      <name>ServerInfo</name>
    </reference>
  </gbean>
</module>


> Deployment plan namespace validation
> ------------------------------------
>
>                 Key: GERONIMO-1642
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-1642
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: deployment, OpenEJB, web
>    Affects Versions: 1.1
>            Reporter: Aaron Mulder
>         Assigned To: Donald Woods
>            Priority: Critical
>             Fix For: 2.0-M6
>
>         Attachments: namespace1642.patch
>
>
> When you deploy with a geronimo deployment plan packaged in the archive, but it has the wrong namespace, the file is ignored.  If anything, you get a message saying the plan is required, or that the archive is not a WAR/JAR/etc.  We should have special detection for geronimo-application.xml, geronimo-ra.xml, geronimo-web.xml, and openejb-jar.xml that notices if the file is present but has the wrong namespace, and prints a suggestive WARN or ERROR message to the console.  Probably for the application.xml, web.xml, ra.xml, and ejb-jar.xml too.
> People have asked for help on the mailing list several times recently when they had this (bad namespace) problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-1642) Deployment plan namespace validation

Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1642?page=all ]

Aaron Mulder updated GERONIMO-1642:
-----------------------------------

    Assign To:     (was: Aaron Mulder)

> Deployment plan namespace validation
> ------------------------------------
>
>          Key: GERONIMO-1642
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1642
>      Project: Geronimo
>         Type: Improvement
>     Security: public(Regular issues) 
>   Components: web, deployment, OpenEJB
>     Versions: 1.1
>     Reporter: Aaron Mulder
>     Priority: Critical
>      Fix For: 1.1.1

>
> When you deploy with a geronimo deployment plan packaged in the archive, but it has the wrong namespace, the file is ignored.  If anything, you get a message saying the plan is required, or that the archive is not a WAR/JAR/etc.  We should have special detection for geronimo-application.xml, geronimo-ra.xml, geronimo-web.xml, and openejb-jar.xml that notices if the file is present but has the wrong namespace, and prints a suggestive WARN or ERROR message to the console.  Probably for the application.xml, web.xml, ra.xml, and ejb-jar.xml too.
> People have asked for help on the mailing list several times recently when they had this (bad namespace) problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-1642) Deployment plan namespace validation

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods updated GERONIMO-1642:
-----------------------------------

       Patch Info:   (was: [Patch Available])
    Fix Version/s:     (was: 2.0-M6)
                   Wish List
         Assignee: Rakesh Midha  (was: Donald Woods)

Patch needs to be reworked to not cause a build failure in client-security....

> Deployment plan namespace validation
> ------------------------------------
>
>                 Key: GERONIMO-1642
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-1642
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: deployment, OpenEJB, web
>    Affects Versions: 1.1
>            Reporter: Aaron Mulder
>         Assigned To: Rakesh Midha
>            Priority: Critical
>             Fix For: Wish List
>
>         Attachments: namespace1642.patch
>
>
> When you deploy with a geronimo deployment plan packaged in the archive, but it has the wrong namespace, the file is ignored.  If anything, you get a message saying the plan is required, or that the archive is not a WAR/JAR/etc.  We should have special detection for geronimo-application.xml, geronimo-ra.xml, geronimo-web.xml, and openejb-jar.xml that notices if the file is present but has the wrong namespace, and prints a suggestive WARN or ERROR message to the console.  Probably for the application.xml, web.xml, ra.xml, and ejb-jar.xml too.
> People have asked for help on the mailing list several times recently when they had this (bad namespace) problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-1642) Deployment plan namespace validation

Posted by "Alan Cabrera (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1642?page=all ]

Alan Cabrera updated GERONIMO-1642:
-----------------------------------

    Fix Version/s: 1.1.x
                       (was: 1.1.1)

Moving unassigned issues over to the 1.1.x pool where they can be worked on for the, in all probability, 1.1.2 patch.

> Deployment plan namespace validation
> ------------------------------------
>
>                 Key: GERONIMO-1642
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-1642
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: web, deployment, OpenEJB
>    Affects Versions: 1.1
>            Reporter: Aaron Mulder
>            Priority: Critical
>             Fix For: 1.1.x
>
>
> When you deploy with a geronimo deployment plan packaged in the archive, but it has the wrong namespace, the file is ignored.  If anything, you get a message saying the plan is required, or that the archive is not a WAR/JAR/etc.  We should have special detection for geronimo-application.xml, geronimo-ra.xml, geronimo-web.xml, and openejb-jar.xml that notices if the file is present but has the wrong namespace, and prints a suggestive WARN or ERROR message to the console.  Probably for the application.xml, web.xml, ra.xml, and ejb-jar.xml too.
> People have asked for help on the mailing list several times recently when they had this (bad namespace) problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (GERONIMO-1642) Deployment plan namespace validation

Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1642?page=all ]

Matt Hogstrom updated GERONIMO-1642:
------------------------------------

    Fix Version: 1.1.1
                     (was: 1.1)
        Version: 1.1
                     (was: 1.0)

> Deployment plan namespace validation
> ------------------------------------
>
>          Key: GERONIMO-1642
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1642
>      Project: Geronimo
>         Type: Improvement
>     Security: public(Regular issues) 
>   Components: web, deployment, OpenEJB
>     Versions: 1.1
>     Reporter: Aaron Mulder
>     Assignee: Aaron Mulder
>     Priority: Critical
>      Fix For: 1.1.1

>
> When you deploy with a geronimo deployment plan packaged in the archive, but it has the wrong namespace, the file is ignored.  If anything, you get a message saying the plan is required, or that the archive is not a WAR/JAR/etc.  We should have special detection for geronimo-application.xml, geronimo-ra.xml, geronimo-web.xml, and openejb-jar.xml that notices if the file is present but has the wrong namespace, and prints a suggestive WARN or ERROR message to the console.  Probably for the application.xml, web.xml, ra.xml, and ejb-jar.xml too.
> People have asked for help on the mailing list several times recently when they had this (bad namespace) problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-1642) Deployment plan namespace validation

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-1642?page=comments#action_12459220 ] 
            
David Jencks commented on GERONIMO-1642:
----------------------------------------

I'm really not sure this is still a problem.  For instance JettyModuleBuilder AFAICT throws an exception explaining the xml problem if it finds a geronimo-web or geronimo-jetty.xml file that it can't interpret.

When looking for examples that fail keep in mind that XmlBeansUtil.parse does a lot of namespace substitution and many builders have code to upgrade documents valid for earlier versions of geronimo plan schemas to the latest versions.  So, "wrong namespace" should mean "namespace we have never used" rather than "not the current namespace"



> Deployment plan namespace validation
> ------------------------------------
>
>                 Key: GERONIMO-1642
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-1642
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: deployment, OpenEJB, web
>    Affects Versions: 1.1
>            Reporter: Aaron Mulder
>         Assigned To: Rakesh Midha
>            Priority: Critical
>             Fix For: 1.1.x
>
>
> When you deploy with a geronimo deployment plan packaged in the archive, but it has the wrong namespace, the file is ignored.  If anything, you get a message saying the plan is required, or that the archive is not a WAR/JAR/etc.  We should have special detection for geronimo-application.xml, geronimo-ra.xml, geronimo-web.xml, and openejb-jar.xml that notices if the file is present but has the wrong namespace, and prints a suggestive WARN or ERROR message to the console.  Probably for the application.xml, web.xml, ra.xml, and ejb-jar.xml too.
> People have asked for help on the mailing list several times recently when they had this (bad namespace) problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (GERONIMO-1642) Deployment plan namespace validation

Posted by "Rakesh Midha (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1642?page=all ]

Rakesh Midha reassigned GERONIMO-1642:
--------------------------------------

    Assignee: Rakesh Midha

> Deployment plan namespace validation
> ------------------------------------
>
>                 Key: GERONIMO-1642
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-1642
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: deployment, OpenEJB, web
>    Affects Versions: 1.1
>            Reporter: Aaron Mulder
>         Assigned To: Rakesh Midha
>            Priority: Critical
>             Fix For: 1.1.x
>
>
> When you deploy with a geronimo deployment plan packaged in the archive, but it has the wrong namespace, the file is ignored.  If anything, you get a message saying the plan is required, or that the archive is not a WAR/JAR/etc.  We should have special detection for geronimo-application.xml, geronimo-ra.xml, geronimo-web.xml, and openejb-jar.xml that notices if the file is present but has the wrong namespace, and prints a suggestive WARN or ERROR message to the console.  Probably for the application.xml, web.xml, ra.xml, and ejb-jar.xml too.
> People have asked for help on the mailing list several times recently when they had this (bad namespace) problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (GERONIMO-1642) Deployment plan namespace validation

Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1642?page=all ]

Aaron Mulder updated GERONIMO-1642:
-----------------------------------

    Fix Version: 1.1
                     (was: 1.2)
      Assign To: Aaron Mulder
       Priority: Critical  (was: Major)

> Deployment plan namespace validation
> ------------------------------------
>
>          Key: GERONIMO-1642
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1642
>      Project: Geronimo
>         Type: Improvement
>     Security: public(Regular issues) 
>   Components: deployment, OpenEJB, web
>     Versions: 1.0
>     Reporter: Aaron Mulder
>     Assignee: Aaron Mulder
>     Priority: Critical
>      Fix For: 1.1

>
> When you deploy with a geronimo deployment plan packaged in the archive, but it has the wrong namespace, the file is ignored.  If anything, you get a message saying the plan is required, or that the archive is not a WAR/JAR/etc.  We should have special detection for geronimo-application.xml, geronimo-ra.xml, geronimo-web.xml, and openejb-jar.xml that notices if the file is present but has the wrong namespace, and prints a suggestive WARN or ERROR message to the console.  Probably for the application.xml, web.xml, ra.xml, and ejb-jar.xml too.
> People have asked for help on the mailing list several times recently when they had this (bad namespace) problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-1642) Deployment plan namespace validation

Posted by "Rakesh Midha (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1642?page=all ]

Rakesh Midha updated GERONIMO-1642:
-----------------------------------

       Patch Info: [Patch Available]
    Fix Version/s: 2.0
                       (was: 1.1.x)
         Assignee:     (was: Rakesh Midha)


Hello David

You are right, in number of cases it is already fixed, but there are still few cases where it is a problem. Though I didnt like the way it is fixed in geronimo-web.xml, via revision 406804. In a way it hardcodes the namespace which I didnt like.

Anyways for failing cases, geronimo-application.xml, openejb-jar.xml and application-client
I attached to patch, which actually doesn't check for any particular version of schema but just validates the root element, and if root element or namespace is wrong it throws 

Cannot find desiredElement "application" with
namespace{http://geronimo.apache.org/xml/ns/j2ee/application-1.2} in
the plan provided.

What do you say? Can you please review it and commit it. It is just short changes and will not take your lot of time. (small amount of changes, but one of those cases where it take lot of time to find the place where fix should go :-) )

Mark patch available and unassigning.

Thanks
Rakesh

> Deployment plan namespace validation
> ------------------------------------
>
>                 Key: GERONIMO-1642
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-1642
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: web, deployment, OpenEJB
>    Affects Versions: 1.1
>            Reporter: Aaron Mulder
>            Priority: Critical
>             Fix For: 2.0
>
>         Attachments: namespace1642.patch
>
>
> When you deploy with a geronimo deployment plan packaged in the archive, but it has the wrong namespace, the file is ignored.  If anything, you get a message saying the plan is required, or that the archive is not a WAR/JAR/etc.  We should have special detection for geronimo-application.xml, geronimo-ra.xml, geronimo-web.xml, and openejb-jar.xml that notices if the file is present but has the wrong namespace, and prints a suggestive WARN or ERROR message to the console.  Probably for the application.xml, web.xml, ra.xml, and ejb-jar.xml too.
> People have asked for help on the mailing list several times recently when they had this (bad namespace) problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira