You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/12/03 13:51:09 UTC

[GitHub] [buildstream-plugins] abderrahim commented on a diff in pull request #39: cmake, autotools, meson: Remove deprecated variables

abderrahim commented on code in PR #39:
URL: https://github.com/apache/buildstream-plugins/pull/39#discussion_r1038779567


##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -31,9 +31,6 @@ variables:
   # Element-specific extra arguments to be passed to `configure`.
   conf-local: ''
 
-  # For backwards compatibility only, do not use.
-  conf-extra: ''
-
   conf-cmd: "%{conf-root}/configure"
   
   conf-args: |

Review Comment:
   maybe we could take the opportunity to stop using `|` and use `>` instead? (and drop the backslashes)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org