[GitHub] [cordova-ios] raphinesse commented on issue #643: test: use verbose spec reporter

[GitBox <gi...@apache.org>]

raphinesse commented on issue #643: test: use verbose spec reporter
URL: https://github.com/apache/cordova-ios/pull/643#issuecomment-573413439
 
 
   > I am definitely in favour of displaying stacktraces on failed tests.
   
   Agreed, but stacktraces for failed tests are displayed by Jasmine's default reporter as well.
   
   The reason I enabled the verbose logging in `cordova-lib` was that it has some long-running tests and I wanted to see how long they take and provide better feedback about the currently executing test when running those long-running tests.
   
   Another advantage of the verbose output is the ability to locate the origin of unwanted console output during tests.
   
   But in case that everything goes well (test finish quickly, no garbage printed to console) I actually prefer the more terse default output when running the tests locally.
   
   I like the solution proposed by @erisu that enables verbose output when running on CI services. Additionally, I would suggest also checking another environment variable that only controls this behavior (e.g. `CDV_VERBOSE_TESTS=1`) so that it can be enabled temporarily when needed locally.
   
   However, to have all advantages that I mentioned above, we should not disable output of successful tests in verbose mode.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org