You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Loyal-Young (via GitHub)" <gi...@apache.org> on 2026/10/15 05:23:53 UTC
[PR] fix(export): reject incomplete full-list pages [rocketmq-dashboard]
Loyal-Young opened a new pull request, #6709:
URL: https://github.com/apache/rocketmq-dashboard/pull/6709
## What is the purpose of the change
Fixes #6708. A full Topic or consumer group scan must not report success when an empty API page still says that records remain unseen. These helpers feed exports, the Topic comparison dialog, and the consumer group selector.
## Brief changelog
- Return normally once the collected count reaches the reported total.
- Reject an empty page with a remaining positive count, including the collected and reported counts in the error.
- Cover both full-list helpers with mocked inconsistent API pages.
## Verification
- Before the fix: both regressions failed because the helpers resolved with one item after an empty second page with `total: 2`.
- After the fix: all 32 Topic and consumer group service tests passed.
- App TypeScript check, changed-file ESLint, and `git diff --check` passed.
## AI assistance
AI assistance helped trace the pagination loops and draft the inconsistent-page regressions. I reproduced the partial-list success on the original code, reviewed the bounded failure behavior, and ran the checks above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(export): reject incomplete full-list pages [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #6709:
URL: https://github.com/apache/rocketmq-dashboard/pull/6709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(export): reject incomplete full-list pages [rocketmq-dashboard]
Posted by "Loyal-Young (via GitHub)" <gi...@apache.org>.
Loyal-Young commented on PR #6709:
URL: https://github.com/apache/rocketmq-dashboard/pull/6709#issuecomment-6261574072
Progress update (2026-10-19): GitHub currently reports the branch as mergeable. All five current CI checks pass. The change is ready for maintainer review. I will follow up on any new feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org