You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/08/12 10:29:22 UTC

[GitHub] [incubator-pegasus] acelyc111 opened a new pull request, #1114: chore: fix docker images conflict by different branches

acelyc111 opened a new pull request, #1114:
URL: https://github.com/apache/incubator-pegasus/pull/1114

   https://github.com/apache/incubator-pegasus/issues/1113
   
   Now different branches of apache repo will push docker images to DockerHub, this will introduce conflicts if they are not compatiable(e.g. thirdparty changes and not compatiable).
   This patch is aim to push differnet name of docker images to DockerHub and will use different images according to the target branch name.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org

[GitHub] [incubator-pegasus] empiredan merged pull request #1114: fix(actions): fix docker images conflict on different branches

Posted by GitBox <gi...@apache.org>.
empiredan merged PR #1114:
URL: https://github.com/apache/incubator-pegasus/pull/1114


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org

[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1114: fix(actions): fix docker images conflict on different branches

Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1114:
URL: https://github.com/apache/incubator-pegasus/pull/1114#discussion_r944983436


##########
.github/workflows/thirdparty-regular-push.yml:
##########
@@ -93,7 +93,7 @@ jobs:
           file: ./docker/thirdparties-bin/Dockerfile
           push: true
           tags: |
-            apache/pegasus:thirdparties-bin-${{ matrix.osversion }}
+            apache/pegasus:thirdparties-bin-${{ matrix.osversion }}-master

Review Comment:
   ```suggestion
               apache/pegasus:thirdparties-bin-${{ matrix.osversion }}-${{ github.ref_name }}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org

[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1114: fix(actions): fix docker images conflict on different branches

Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1114:
URL: https://github.com/apache/incubator-pegasus/pull/1114#discussion_r944983129


##########
.github/workflows/thirdparty-regular-push.yml:
##########
@@ -58,7 +58,7 @@ jobs:
           file: ./docker/thirdparties-src/Dockerfile
           push: true
           tags: |
-            apache/pegasus:thirdparties-src
+            apache/pegasus:thirdparties-src-master

Review Comment:
   ```suggestion
               apache/pegasus:thirdparties-src-${{ github.ref_name }}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org

[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1114: fix(actions): fix docker images conflict on different branches

Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1114:
URL: https://github.com/apache/incubator-pegasus/pull/1114#discussion_r944913067


##########
.github/workflows/thirdparty-regular-push.yml:
##########
@@ -58,7 +58,7 @@ jobs:
           file: ./docker/thirdparties-src/Dockerfile
           push: true
           tags: |
-            apache/pegasus:thirdparties-src
+            apache/pegasus:thirdparties-src-${{ github.ref_name }}

Review Comment:
   ```suggestion
               apache/pegasus:thirdparties-src-master
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org