You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2023/05/11 20:17:55 UTC
[GitHub] [netbeans] mbien opened a new pull request, #5936: upgrade bundled maven to 3.9.2.
mbien opened a new pull request, #5936:
URL: https://github.com/apache/netbeans/pull/5936
minor dependency update from 3.9.1 to 3.9.2 of bundled maven
changes:
https://maven.apache.org/docs/3.9.2/release-notes.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5936: upgrade bundled maven to 3.9.2.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#discussion_r1192128753
##########
java/maven.embedder/external/binariesembedded-list:
##########
@@ -17,44 +17,44 @@
0235BA8B489512805AC13A8F9EA77A1CA5EBE3E8;org.aopalliance:aopalliance:1.0
1194890E6F56EC29177673F2F12D0B8E627DEC98;org.apache.httpcomponents:httpclient:4.5.14
-7F2E0C573EAA7A74BAC2E89B359E1F73D92A0A1D;org.apache.httpcomponents:httpcore:4.5.15
+51CF043C87253C9F58B539C9F7E44C8894223850;org.apache.httpcomponents:httpcore:4.4.16
Review Comment:
opened a PR for this #5939 in case we have to fix it. I didn't check the rest of the versions - this was just a coincidence that I saw it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on a diff in pull request #5936: upgrade bundled maven to 3.9.2.
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#discussion_r1192263718
##########
java/maven.embedder/external/binariesembedded-list:
##########
@@ -17,44 +17,44 @@
0235BA8B489512805AC13A8F9EA77A1CA5EBE3E8;org.aopalliance:aopalliance:1.0
1194890E6F56EC29177673F2F12D0B8E627DEC98;org.apache.httpcomponents:httpclient:4.5.14
-7F2E0C573EAA7A74BAC2E89B359E1F73D92A0A1D;org.apache.httpcomponents:httpcore:4.5.15
+51CF043C87253C9F58B539C9F7E44C8894223850;org.apache.httpcomponents:httpcore:4.4.16
Review Comment:
maybe restricting netbeans-tlp master build (release and not everything) so snapshot will be less and we could do IT on it.
I forget that staging require signing that implies human and 30mins to sign every bits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #5936: upgrade bundled maven to 3.9.2.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #5936:
URL: https://github.com/apache/netbeans/pull/5936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on a diff in pull request #5936: upgrade bundled maven to 3.9.2.
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#discussion_r1192210871
##########
java/maven.embedder/external/binariesembedded-list:
##########
@@ -17,44 +17,44 @@
0235BA8B489512805AC13A8F9EA77A1CA5EBE3E8;org.aopalliance:aopalliance:1.0
1194890E6F56EC29177673F2F12D0B8E627DEC98;org.apache.httpcomponents:httpclient:4.5.14
-7F2E0C573EAA7A74BAC2E89B359E1F73D92A0A1D;org.apache.httpcomponents:httpcore:4.5.15
+51CF043C87253C9F58B539C9F7E44C8894223850;org.apache.httpcomponents:httpcore:4.4.16
Review Comment:
It's release critical (for platform maven users), and good findings to get it before release.
pom from org-netbeans-modules-maven-embedder-RELEASE180 contains that (from zip in ci build)
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpcore</artifactId>
<version>4.5.15</version>
<classifier></classifier>
</dependency>
and thats not good will lead to issue for user later after release. Because not everyone is using that dependency.
I fully aggree for additional tooling.
Also may want to auto stage on release build if possible as it's apache / apache so we may have early test. (Snapshot are not exacly the same tree as the populating of snapshot is not limited to release cluster)
So additionnal build could have a integration test application to check all clusters pom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5936: upgrade bundled maven to 3.9.2.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#discussion_r1191652318
##########
java/maven.embedder/external/binariesembedded-list:
##########
@@ -17,44 +17,44 @@
0235BA8B489512805AC13A8F9EA77A1CA5EBE3E8;org.aopalliance:aopalliance:1.0
1194890E6F56EC29177673F2F12D0B8E627DEC98;org.apache.httpcomponents:httpclient:4.5.14
-7F2E0C573EAA7A74BAC2E89B359E1F73D92A0A1D;org.apache.httpcomponents:httpcore:4.5.15
+51CF043C87253C9F58B539C9F7E44C8894223850;org.apache.httpcomponents:httpcore:4.4.16
Review Comment:
this version was actually wrong. Was a copy/paste/typo from last time I updated this. Not sure what consequences this has @ebarboni @matthiasblaesing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on a diff in pull request #5936: upgrade bundled maven to 3.9.2.
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#discussion_r1192099506
##########
java/maven.embedder/external/binariesembedded-list:
##########
@@ -17,44 +17,44 @@
0235BA8B489512805AC13A8F9EA77A1CA5EBE3E8;org.aopalliance:aopalliance:1.0
1194890E6F56EC29177673F2F12D0B8E627DEC98;org.apache.httpcomponents:httpclient:4.5.14
-7F2E0C573EAA7A74BAC2E89B359E1F73D92A0A1D;org.apache.httpcomponents:httpcore:4.5.15
+51CF043C87253C9F58B539C9F7E44C8894223850;org.apache.httpcomponents:httpcore:4.4.16
Review Comment:
@mbien @neilcsmith-net sorry this is an issue, it will generate a pom with 4.5.15 as hash is correct it will map to the maven artefacts no brain. Only way to figure out is on vote :/ this is late.
maybe the binariesembedded-list should be used to download the way binaris-list too to check that in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5936: upgrade bundled maven to 3.9.2.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#discussion_r1194979010
##########
java/maven.embedder/build.xml:
##########
@@ -21,16 +21,13 @@
-->
<project basedir="." default="build" name="java/maven.embedder">
<import file="../../nbbuild/templates/projectized.xml"/>
- <target name="-release.files" depends="projectized.-release.files">
+ <target name="-release.files" depends="projectized.-release.files,check-binariesembedded-list">
Review Comment:
I tested the list manually with this: https://github.com/apache/netbeans/pull/5939#issuecomment-1545628713
we should think about the whole approach a bit more since this doesn't feel right to me. Instead of validating the list after doing an error prone manual update we should think about generating it from https://github.com/apache/maven/blob/master/pom.xml or something equivalent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5936: upgrade bundled maven to 3.9.2.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#issuecomment-1544695527
all green except papwerwork. going to fix the overlaps file without all-tests enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on a diff in pull request #5936: upgrade bundled maven to 3.9.2.
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#discussion_r1195097145
##########
java/maven.embedder/build.xml:
##########
@@ -21,16 +21,13 @@
-->
<project basedir="." default="build" name="java/maven.embedder">
<import file="../../nbbuild/templates/projectized.xml"/>
- <target name="-release.files" depends="projectized.-release.files">
+ <target name="-release.files" depends="projectized.-release.files,check-binariesembedded-list">
Review Comment:
ok, well done. I'm not sure it will be easy to get info from "bom" .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on a diff in pull request #5936: upgrade bundled maven to 3.9.2.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on code in PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#discussion_r1192241311
##########
java/maven.embedder/external/binariesembedded-list:
##########
@@ -17,44 +17,44 @@
0235BA8B489512805AC13A8F9EA77A1CA5EBE3E8;org.aopalliance:aopalliance:1.0
1194890E6F56EC29177673F2F12D0B8E627DEC98;org.apache.httpcomponents:httpclient:4.5.14
-7F2E0C573EAA7A74BAC2E89B359E1F73D92A0A1D;org.apache.httpcomponents:httpcore:4.5.15
+51CF043C87253C9F58B539C9F7E44C8894223850;org.apache.httpcomponents:httpcore:4.4.16
Review Comment:
@ebarboni if you think this is release critical, please review #5939 then add the `priority:critical` label and we can look at building an 18-rc4 early next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5936: upgrade bundled maven to 3.9.2.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#discussion_r1191652318
##########
java/maven.embedder/external/binariesembedded-list:
##########
@@ -17,44 +17,44 @@
0235BA8B489512805AC13A8F9EA77A1CA5EBE3E8;org.aopalliance:aopalliance:1.0
1194890E6F56EC29177673F2F12D0B8E627DEC98;org.apache.httpcomponents:httpclient:4.5.14
-7F2E0C573EAA7A74BAC2E89B359E1F73D92A0A1D;org.apache.httpcomponents:httpcore:4.5.15
+51CF043C87253C9F58B539C9F7E44C8894223850;org.apache.httpcomponents:httpcore:4.4.16
Review Comment:
this version was actually wrong. Was a copy/paste/typo from last time I updated this. Not sure what consequences this has @ebresie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on a diff in pull request #5936: upgrade bundled maven to 3.9.2.
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#discussion_r1194849812
##########
java/maven.embedder/build.xml:
##########
@@ -21,16 +21,13 @@
-->
<project basedir="." default="build" name="java/maven.embedder">
<import file="../../nbbuild/templates/projectized.xml"/>
- <target name="-release.files" depends="projectized.-release.files">
+ <target name="-release.files" depends="projectized.-release.files,check-binariesembedded-list">
Review Comment:
+1 but maybe we should add the download check, if artifcat coordinate is semanticaly correct but not present on central would it fail ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on a diff in pull request #5936: upgrade bundled maven to 3.9.2.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on code in PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#discussion_r1192124367
##########
java/maven.embedder/external/binariesembedded-list:
##########
@@ -17,44 +17,44 @@
0235BA8B489512805AC13A8F9EA77A1CA5EBE3E8;org.aopalliance:aopalliance:1.0
1194890E6F56EC29177673F2F12D0B8E627DEC98;org.apache.httpcomponents:httpclient:4.5.14
-7F2E0C573EAA7A74BAC2E89B359E1F73D92A0A1D;org.apache.httpcomponents:httpcore:4.5.15
+51CF043C87253C9F58B539C9F7E44C8894223850;org.apache.httpcomponents:httpcore:4.4.16
Review Comment:
We really need to generate this file from the zip in the build! :smile:
I'm not sure I understand @ebarboni what the implications are here? Will this only show as a problem on release or will it show up in snapshots? Do we need to fix in delivery?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5936: upgrade bundled maven to 3.9.2.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#issuecomment-1545742801
draft until fix was synced back from delivery, after that I am going to fix the list here and force push
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5936: upgrade bundled maven to 3.9.2.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#discussion_r1191652318
##########
java/maven.embedder/external/binariesembedded-list:
##########
@@ -17,44 +17,44 @@
0235BA8B489512805AC13A8F9EA77A1CA5EBE3E8;org.aopalliance:aopalliance:1.0
1194890E6F56EC29177673F2F12D0B8E627DEC98;org.apache.httpcomponents:httpclient:4.5.14
-7F2E0C573EAA7A74BAC2E89B359E1F73D92A0A1D;org.apache.httpcomponents:httpcore:4.5.15
+51CF043C87253C9F58B539C9F7E44C8894223850;org.apache.httpcomponents:httpcore:4.4.16
Review Comment:
this version was actually wrong. Was a copy/paste/typo from last time I updated this. Not sure what consequences this has for NB 18 @ebarboni @matthiasblaesing @neilcsmith-net
it was correct in project.xml:
https://github.com/apache/netbeans/blob/75bb740f9d75f237159677f4f0410271b40ece52/java/maven.embedder/nbproject/project.xml#L317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5936: upgrade bundled maven to 3.9.2.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#discussion_r1191652318
##########
java/maven.embedder/external/binariesembedded-list:
##########
@@ -17,44 +17,44 @@
0235BA8B489512805AC13A8F9EA77A1CA5EBE3E8;org.aopalliance:aopalliance:1.0
1194890E6F56EC29177673F2F12D0B8E627DEC98;org.apache.httpcomponents:httpclient:4.5.14
-7F2E0C573EAA7A74BAC2E89B359E1F73D92A0A1D;org.apache.httpcomponents:httpcore:4.5.15
+51CF043C87253C9F58B539C9F7E44C8894223850;org.apache.httpcomponents:httpcore:4.4.16
Review Comment:
this version was actually wrong. Was a copy/paste/typo from last time I updated this. Not sure what consequences this has for NB 18 @ebarboni @matthiasblaesing @neilcsmith-net
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5936: upgrade bundled maven to 3.9.2.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#discussion_r1194394296
##########
java/maven.embedder/build.xml:
##########
@@ -21,16 +21,13 @@
-->
<project basedir="." default="build" name="java/maven.embedder">
<import file="../../nbbuild/templates/projectized.xml"/>
- <target name="-release.files" depends="projectized.-release.files">
+ <target name="-release.files" depends="projectized.-release.files,check-binariesembedded-list">
Review Comment:
the task is now part of the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists