You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/10/12 15:27:59 UTC
[GitHub] [incubator-devlake] abeizn opened a new pull request, #3404: fix: ineffectual e2e test case for calculateChangeLeadTime
abeizn opened a new pull request, #3404:
URL: https://github.com/apache/incubator-devlake/pull/3404
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [ ] I have read through the [Contributing Documentation](https://devlake.apache.org/community/).
- [ ] I have added relevant tests.
- [ ] I have added relevant documentation.
- [ ] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc.
# Summary
fix: ineffectual e2e test case for calculateChangeLeadTime
### Does this close any open issues?
Closes #3400
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #3404: fix: ineffectual e2e test case for calculateChangeLeadTime
Posted by GitBox <gi...@apache.org>.
abeizn commented on code in PR #3404:
URL: https://github.com/apache/incubator-devlake/pull/3404#discussion_r994153080
##########
plugins/dora/e2e/calculate_change_lead_time_test.go:
##########
@@ -45,7 +44,7 @@ func TestCalculateCLTimeDataFlow(t *testing.T) {
dataflowTester.FlushTabler(&code.PullRequest{})
// import raw data table
dataflowTester.ImportCsvIntoTabler("./raw_tables/lake_cicd_pipeline_commits.csv", &devops.CiCDPipelineCommit{})
Review Comment:
> I think some of the imported tables are not needed anymore, please check and remove those.
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on a diff in pull request #3404: fix: ineffectual e2e test case for calculateChangeLeadTime
Posted by GitBox <gi...@apache.org>.
klesh commented on code in PR #3404:
URL: https://github.com/apache/incubator-devlake/pull/3404#discussion_r994078330
##########
plugins/dora/e2e/calculate_change_lead_time_test.go:
##########
@@ -45,7 +44,7 @@ func TestCalculateCLTimeDataFlow(t *testing.T) {
dataflowTester.FlushTabler(&code.PullRequest{})
// import raw data table
dataflowTester.ImportCsvIntoTabler("./raw_tables/lake_cicd_pipeline_commits.csv", &devops.CiCDPipelineCommit{})
Review Comment:
I think some of the imported tables are not needed anymore, please check and remove those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh merged pull request #3404: fix: ineffectual e2e test case for calculateChangeLeadTime
Posted by GitBox <gi...@apache.org>.
klesh merged PR #3404:
URL: https://github.com/apache/incubator-devlake/pull/3404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org