You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/20 05:33:46 UTC
Review Request 67668: Fixed a bug in `TestCSIPlugin::DeleteVolume`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67668/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Bugs: MESOS-8995
https://issues.apache.org/jira/browse/MESOS-8995
Repository: mesos
Description
-------
The test CSI plugin mistakenly reduce the available capacity instead of
expanding it when deleting a volume. This patch fixes this bug.
Diffs
-----
src/examples/test_csi_plugin.cpp 9c4da8811cc260bcf3bccfea3036a7964cb75697
Diff: https://reviews.apache.org/r/67668/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 67668: Fixed a bug in
`TestCSIPlugin::DeleteVolume`.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67668/
-----------------------------------------------------------
(Updated June 21, 2018, 4:35 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Addressed Benjamin's comment.
Bugs: MESOS-8995
https://issues.apache.org/jira/browse/MESOS-8995
Repository: mesos
Description
-------
The test CSI plugin mistakenly reduce the available capacity instead of
expanding it when deleting a volume. This patch fixes this bug.
Diffs (updated)
-----
src/examples/test_csi_plugin.cpp 9c4da8811cc260bcf3bccfea3036a7964cb75697
Diff: https://reviews.apache.org/r/67668/diff/2/
Changes: https://reviews.apache.org/r/67668/diff/1-2/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 67668: Fixed a bug in
`TestCSIPlugin::DeleteVolume`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67668/#review205058
-----------------------------------------------------------
Ship it!
src/examples/test_csi_plugin.cpp
Line 364 (original), 364 (patched)
<https://reviews.apache.org/r/67668/#comment287966>
Unrelated, but we might want to put a `CHECK` like the one on l.127 here.
- Benjamin Bannier
On June 20, 2018, 7:33 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67668/
> -----------------------------------------------------------
>
> (Updated June 20, 2018, 7:33 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8995
> https://issues.apache.org/jira/browse/MESOS-8995
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test CSI plugin mistakenly reduce the available capacity instead of
> expanding it when deleting a volume. This patch fixes this bug.
>
>
> Diffs
> -----
>
> src/examples/test_csi_plugin.cpp 9c4da8811cc260bcf3bccfea3036a7964cb75697
>
>
> Diff: https://reviews.apache.org/r/67668/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>