You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/12 05:24:22 UTC
[GitHub] [shardingsphere] tristaZero opened a new issue #8143: Format input parameters for visitXXX() functions
tristaZero opened a new issue #8143:
URL: https://github.com/apache/shardingsphere/issues/8143
### Background
Considering the check-style for functions,
` public ASTNode visitQuerySpecification(final QuerySpecificationContext ctx) ` is expected rather than
` public ASTNode visitQuerySpecification(final MySQLStatementParser.QuerySpecificationContext ctx) `.
Hence, this issue aims to correct the nonstandard `visit` function check-style.
### How?
1. Enter into directory `~/shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-dialect`.
2. All the target classes in `src/main/java/org/apache/shardingsphere/sql/parser/${database Name}/visitor/`.
- As you can see, basically, most of the function names are in the form of `visitXXX()`.
3. If you find that the input parameter is in the style of `final MySQLStatementParser.QuerySpecificationContext ctx`, please modify it to `final QuerySpecificationContext ctx`.
This issue is simply understanding, though, it will take you some of the time. :) So All the changes in one PR or a few PRs with a part of changes are both ok.
Waiting for your contribution!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #8143: Format input parameters for visitor functions
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #8143:
URL: https://github.com/apache/shardingsphere/issues/8143#issuecomment-726048563
@wenweibin Welcome!!!๐๐๐
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wenweibin commented on issue #8143: Format input parameters for visitor functions
Posted by GitBox <gi...@apache.org>.
wenweibin commented on issue #8143:
URL: https://github.com/apache/shardingsphere/issues/8143#issuecomment-725995625
This is really a good first issue, and if nobody want to fix it๏ผplease assgin to me. ๐
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking closed issue #8143: Format input parameters for visitor functions
Posted by GitBox <gi...@apache.org>.
kimmking closed issue #8143:
URL: https://github.com/apache/shardingsphere/issues/8143
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org