You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2020/11/19 04:09:21 UTC

[impala] 01/02: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3

This is an automated email from the ASF dual-hosted git repository.

tarmstrong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit c9ccb61acb6d0060de10833b4b37df096baa2cd3
Author: Vihang Karajgaonkar <vi...@apache.org>
AuthorDate: Wed Nov 18 10:34:14 2020 -0800

    IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3
    
    This patch disables metadata/test_catalogd_debug_actions
    test on S3 builds due to its flakiness. The root cause of this
    seems to be that listing time on S3 is variable and the test
    becomes flaky because it measures the time taken by refresh
    command after a certain debug action is set.
    
    Testing:
    1. Ran the test on my local environment to make sure it
    compiles fine.
    
    Change-Id: I30bd10de468ad449c4a143a65cdcba97d9f0cd78
    Reviewed-on: http://gerrit.cloudera.org:8080/16745
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/common/skip.py                          | 2 ++
 tests/metadata/test_catalogd_debug_actions.py | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/tests/common/skip.py b/tests/common/skip.py
index 37ace22..b9aa6c8 100644
--- a/tests/common/skip.py
+++ b/tests/common/skip.py
@@ -63,6 +63,8 @@ class SkipIfS3:
       reason="Flakiness on account of S3 eventual consistency.")
   iceberg = pytest.mark.skipif(IS_S3,
       reason="Currently Iceberg is only supported on HDFS.")
+  variable_listing_times = pytest.mark.skipif(IS_S3,
+      reason="Flakiness due to unpredictable listing times on S3.")
 
 
 class SkipIfABFS:
diff --git a/tests/metadata/test_catalogd_debug_actions.py b/tests/metadata/test_catalogd_debug_actions.py
index 01461fb..ade7e87 100644
--- a/tests/metadata/test_catalogd_debug_actions.py
+++ b/tests/metadata/test_catalogd_debug_actions.py
@@ -17,8 +17,10 @@
 
 import pytest
 from tests.common.impala_test_suite import ImpalaTestSuite
+from tests.common.skip import SkipIfS3
 
 
+@SkipIfS3.variable_listing_times
 class TestDebugActions(ImpalaTestSuite):
 
   @pytest.mark.execute_serially