You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Tristan Stevens <tr...@cloudera.com> on 2016/10/17 19:29:22 UTC
Review Request 52955: FLUME-2698 - Upgrade Jetty Version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52955/
-----------------------------------------------------------
Review request for Flume.
Repository: flume-git
Description
-------
This patch upgrades the HTTPSource and HTTP Metrics server to Jetty 9.2 (N.B. 9.3/9.4 depend on JDK8). It also adds the ability to further configure the Jetty server and also run in multi-threaded mode.
Diffs
-----
flume-ng-core/pom.xml 2262d94
flume-ng-core/src/main/java/org/apache/flume/instrumentation/MonitoringType.java 4e1a28c
flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 921a1f7
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java 38bdfda
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java 86caf7d
flume-ng-core/src/main/java/org/apache/flume/tools/FlumeBeanConfigurator.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/tools/HTTPServerConstraintUtil.java 479cfc4
flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java 09d419f
flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java 475d92f
flume-ng-core/src/test/java/org/apache/flume/source/http/TestBLOBHandler.java f770d51
flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 3ad8282
flume-ng-legacy-sources/flume-avro-source/pom.xml 7cecde2
flume-ng-legacy-sources/flume-thrift-source/pom.xml 1ceeb5b
flume-ng-sources/flume-scribe-source/pom.xml 73641df
pom.xml f62c99a
Diff: https://reviews.apache.org/r/52955/diff/
Testing
-------
Passes existing unit tests, further tests to follow.
Thanks,
Tristan Stevens
Re: Review Request 52955: FLUME-2698 - Upgrade Jetty Version
Posted by Miklos Csanady <mi...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52955/#review184039
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Csanady
On Aug. 24, 2017, 8:32 p.m., Tristan Stevens wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52955/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2017, 8:32 p.m.)
>
>
> Review request for Flume.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> This patch upgrades the HTTPSource and HTTP Metrics server to Jetty 9.4. It also adds the ability to further configure the Jetty server and also run in multi-threaded mode. Finally, registered Jetty with the MBeans server to allow fine-grained performance tuning/monitoring if required.
>
>
> Diffs
> -----
>
> flume-ng-core/pom.xml e2ecd6ee
> flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 921a1f74
> flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java 38bdfda6
> flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java 86caf7d7
> flume-ng-core/src/main/java/org/apache/flume/tools/FlumeBeanConfigurator.java PRE-CREATION
> flume-ng-core/src/main/java/org/apache/flume/tools/HTTPServerConstraintUtil.java 479cfc46
> flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java 09d419f4
> flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java 475d92fe
> flume-ng-core/src/test/java/org/apache/flume/source/http/TestBLOBHandler.java f770d511
> flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 3ad82829
> flume-ng-doc/sphinx/FlumeUserGuide.rst 209db481
> flume-ng-legacy-sources/flume-avro-source/pom.xml 46d301b5
> flume-ng-legacy-sources/flume-thrift-source/pom.xml cb50473d
> flume-ng-sinks/flume-http-sink/pom.xml 3f8cfc88
> flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/FlumeHttpServletRequestWrapper.java 9711a3ad
> flume-ng-sources/flume-scribe-source/pom.xml 75fc085f
> pom.xml c0bd052b
>
>
> Diff: https://reviews.apache.org/r/52955/diff/6/
>
>
> Testing
> -------
>
> Passes existing unit tests, added specific tests for configurability aspects and also for JMX monitoring.
>
>
> File Attachments
> ----------------
>
> FLUME-2698-4.patch
> https://reviews.apache.org/media/uploaded/files/2017/07/17/b0a55da7-1b6a-4ae1-aea5-d6efa7a43c69__FLUME-2698-4.patch
>
>
> Thanks,
>
> Tristan Stevens
>
>
Re: Review Request 52955: FLUME-2698 - Upgrade Jetty Version
Posted by Tristan Stevens <tr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52955/
-----------------------------------------------------------
(Updated Aug. 24, 2017, 8:32 p.m.)
Review request for Flume.
Changes
-------
Fix checkstyle error
Repository: flume-git
Description
-------
This patch upgrades the HTTPSource and HTTP Metrics server to Jetty 9.4. It also adds the ability to further configure the Jetty server and also run in multi-threaded mode. Finally, registered Jetty with the MBeans server to allow fine-grained performance tuning/monitoring if required.
Diffs (updated)
-----
flume-ng-core/pom.xml e2ecd6ee
flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 921a1f74
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java 38bdfda6
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java 86caf7d7
flume-ng-core/src/main/java/org/apache/flume/tools/FlumeBeanConfigurator.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/tools/HTTPServerConstraintUtil.java 479cfc46
flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java 09d419f4
flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java 475d92fe
flume-ng-core/src/test/java/org/apache/flume/source/http/TestBLOBHandler.java f770d511
flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 3ad82829
flume-ng-doc/sphinx/FlumeUserGuide.rst 209db481
flume-ng-legacy-sources/flume-avro-source/pom.xml 46d301b5
flume-ng-legacy-sources/flume-thrift-source/pom.xml cb50473d
flume-ng-sinks/flume-http-sink/pom.xml 3f8cfc88
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/FlumeHttpServletRequestWrapper.java 9711a3ad
flume-ng-sources/flume-scribe-source/pom.xml 75fc085f
pom.xml c0bd052b
Diff: https://reviews.apache.org/r/52955/diff/6/
Changes: https://reviews.apache.org/r/52955/diff/5-6/
Testing
-------
Passes existing unit tests, added specific tests for configurability aspects and also for JMX monitoring.
File Attachments
----------------
FLUME-2698-4.patch
https://reviews.apache.org/media/uploaded/files/2017/07/17/b0a55da7-1b6a-4ae1-aea5-d6efa7a43c69__FLUME-2698-4.patch
Thanks,
Tristan Stevens
Re: Review Request 52955: FLUME-2698 - Upgrade Jetty Version
Posted by Tristan Stevens <tr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52955/
-----------------------------------------------------------
(Updated Aug. 24, 2017, 5:41 p.m.)
Review request for Flume.
Changes
-------
Update following comments received offline
Repository: flume-git
Description
-------
This patch upgrades the HTTPSource and HTTP Metrics server to Jetty 9.4. It also adds the ability to further configure the Jetty server and also run in multi-threaded mode. Finally, registered Jetty with the MBeans server to allow fine-grained performance tuning/monitoring if required.
Diffs (updated)
-----
flume-ng-core/pom.xml e2ecd6ee
flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 921a1f74
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java 38bdfda6
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java 86caf7d7
flume-ng-core/src/main/java/org/apache/flume/tools/FlumeBeanConfigurator.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/tools/HTTPServerConstraintUtil.java 479cfc46
flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java 09d419f4
flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java 475d92fe
flume-ng-core/src/test/java/org/apache/flume/source/http/TestBLOBHandler.java f770d511
flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 3ad82829
flume-ng-doc/sphinx/FlumeUserGuide.rst 209db481
flume-ng-legacy-sources/flume-avro-source/pom.xml 46d301b5
flume-ng-legacy-sources/flume-thrift-source/pom.xml cb50473d
flume-ng-sinks/flume-http-sink/pom.xml 3f8cfc88
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/FlumeHttpServletRequestWrapper.java 9711a3ad
flume-ng-sources/flume-scribe-source/pom.xml 75fc085f
pom.xml c0bd052b
Diff: https://reviews.apache.org/r/52955/diff/5/
Changes: https://reviews.apache.org/r/52955/diff/4-5/
Testing
-------
Passes existing unit tests, added specific tests for configurability aspects and also for JMX monitoring.
File Attachments
----------------
FLUME-2698-4.patch
https://reviews.apache.org/media/uploaded/files/2017/07/17/b0a55da7-1b6a-4ae1-aea5-d6efa7a43c69__FLUME-2698-4.patch
Thanks,
Tristan Stevens
Re: Review Request 52955: FLUME-2698 - Upgrade Jetty Version
Posted by Tristan Stevens <tr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52955/
-----------------------------------------------------------
(Updated July 17, 2017, 7:06 p.m.)
Review request for Flume.
Changes
-------
Change description and update following comments.
Repository: flume-git
Description (updated)
-------
This patch upgrades the HTTPSource and HTTP Metrics server to Jetty 9.4. It also adds the ability to further configure the Jetty server and also run in multi-threaded mode. Finally, registered Jetty with the MBeans server to allow fine-grained performance tuning/monitoring if required.
Diffs (updated)
-----
flume-ng-core/pom.xml 2262d94f
flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 921a1f74
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java 38bdfda6
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java 86caf7d7
flume-ng-core/src/main/java/org/apache/flume/tools/FlumeBeanConfigurator.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/tools/HTTPServerConstraintUtil.java 479cfc46
flume-ng-core/src/main/java/org/apache/flume/tools/ImmutablePair.java PRE-CREATION
flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java 09d419f4
flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java 475d92fe
flume-ng-core/src/test/java/org/apache/flume/source/http/TestBLOBHandler.java f770d511
flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 3ad82829
flume-ng-doc/sphinx/FlumeUserGuide.rst 209db481
flume-ng-legacy-sources/flume-avro-source/pom.xml 7cecde22
flume-ng-legacy-sources/flume-thrift-source/pom.xml 1ceeb5b5
flume-ng-sources/flume-scribe-source/pom.xml 73641dfd
pom.xml 5730db0c
Diff: https://reviews.apache.org/r/52955/diff/4/
Changes: https://reviews.apache.org/r/52955/diff/3-4/
Testing
-------
Passes existing unit tests, added specific tests for configurability aspects and also for JMX monitoring.
File Attachments (updated)
----------------
FLUME-2698-4.patch
https://reviews.apache.org/media/uploaded/files/2017/07/17/b0a55da7-1b6a-4ae1-aea5-d6efa7a43c69__FLUME-2698-4.patch
Thanks,
Tristan Stevens
Re: Review Request 52955: FLUME-2698 - Upgrade Jetty Version
Posted by Tristan Stevens <tr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52955/
-----------------------------------------------------------
(Updated June 28, 2017, 12:55 p.m.)
Review request for Flume.
Changes
-------
Update for JDK1.8 and Jetty 9.4 changes.
Repository: flume-git
Description
-------
This patch upgrades the HTTPSource and HTTP Metrics server to Jetty 9.2 (N.B. 9.3/9.4 depend on JDK8). It also adds the ability to further configure the Jetty server and also run in multi-threaded mode. Finally, registered Jetty with the MBeans server to allow fine-grained performance tuning/monitoring if required.
Diffs (updated)
-----
flume-ng-core/pom.xml 2262d94f
flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 921a1f74
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java 38bdfda6
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java 86caf7d7
flume-ng-core/src/main/java/org/apache/flume/tools/FlumeBeanConfigurator.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/tools/HTTPServerConstraintUtil.java 479cfc46
flume-ng-core/src/main/java/org/apache/flume/tools/ImmutablePair.java PRE-CREATION
flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java 09d419f4
flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java 475d92fe
flume-ng-core/src/test/java/org/apache/flume/source/http/TestBLOBHandler.java f770d511
flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 3ad82829
flume-ng-doc/sphinx/FlumeUserGuide.rst 2073bf63
flume-ng-legacy-sources/flume-avro-source/pom.xml 7cecde22
flume-ng-legacy-sources/flume-thrift-source/pom.xml 1ceeb5b5
flume-ng-sources/flume-scribe-source/pom.xml 73641dfd
pom.xml 5730db0c
Diff: https://reviews.apache.org/r/52955/diff/3/
Changes: https://reviews.apache.org/r/52955/diff/2-3/
Testing
-------
Passes existing unit tests, added specific tests for configurability aspects and also for JMX monitoring.
Thanks,
Tristan Stevens
Re: Review Request 52955: FLUME-2698 - Upgrade Jetty Version
Posted by Tristan Stevens <tr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52955/
-----------------------------------------------------------
(Updated Oct. 18, 2016, 4:03 p.m.)
Review request for Flume.
Changes
-------
Added tests, JMX and changed reference to released stable version of Jetty 9.2.19.v20160908. This diff should now be stable and passes tests and checkstyle.
Repository: flume-git
Description (updated)
-------
This patch upgrades the HTTPSource and HTTP Metrics server to Jetty 9.2 (N.B. 9.3/9.4 depend on JDK8). It also adds the ability to further configure the Jetty server and also run in multi-threaded mode. Finally, registered Jetty with the MBeans server to allow fine-grained performance tuning/monitoring if required.
Diffs (updated)
-----
flume-ng-core/pom.xml 2262d94
flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 921a1f7
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java 38bdfda
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java 86caf7d
flume-ng-core/src/main/java/org/apache/flume/tools/FlumeBeanConfigurator.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/tools/HTTPServerConstraintUtil.java 479cfc4
flume-ng-core/src/main/java/org/apache/flume/tools/ImmutablePair.java PRE-CREATION
flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java 09d419f
flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java 475d92f
flume-ng-core/src/test/java/org/apache/flume/source/http/TestBLOBHandler.java f770d51
flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 3ad8282
flume-ng-doc/sphinx/FlumeUserGuide.rst cd76bb3
flume-ng-legacy-sources/flume-avro-source/pom.xml 7cecde2
flume-ng-legacy-sources/flume-thrift-source/pom.xml 1ceeb5b
flume-ng-sources/flume-scribe-source/pom.xml 73641df
pom.xml f62c99a
Diff: https://reviews.apache.org/r/52955/diff/
Testing (updated)
-------
Passes existing unit tests, added specific tests for configurability aspects and also for JMX monitoring.
Thanks,
Tristan Stevens
Re: Review Request 52955: FLUME-2698 - Upgrade Jetty Version
Posted by Tristan Stevens <tr...@cloudera.com>.
> On Oct. 17, 2016, 7:51 p.m., Lior Zeno wrote:
> > Thanks for your contribution!
> >
> > There is an open ticket for bumping java version to 8. Will your patch change much if we upgrade to the latest Jetty version?
Hi @Lior, no - not much changes at all. I've justed tested against JDK8 and Jetty 9.3.12.v20160915 (which is the latest stable version) and it compiles and runs tests fine. 9.4 does not appear so happy, but there is not yet a stable release of 9.4 so I'm not so worried about that.
This has flagged an issue, that the latest stable release of 9.2 is 9.2.19.v20160908 and not 9.2.12.M0 - I'll address that in the next patch.
Here is the diff I tested against:
```
diff --git a/pom.xml b/pom.xml
index 8372210..ba66c9f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -37,8 +37,8 @@ limitations under the License.
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<!-- Java compiler configuration -->
- <sourceJavaVersion>1.7</sourceJavaVersion>
- <targetJavaVersion>1.7</targetJavaVersion>
+ <sourceJavaVersion>1.8</sourceJavaVersion>
+ <targetJavaVersion>1.8</targetJavaVersion>
<!-- defaults for flaky test and focused test exclusions -->
<test.exclude.pattern>$</test.exclude.pattern> <!-- junk pattern -->
@@ -942,19 +942,19 @@ limitations under the License.
<dependency>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-servlet</artifactId>
- <version>9.2.12.M0</version>
+ <version>9.3.12.v20160915</version>
</dependency>
<dependency>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-util</artifactId>
- <version>9.2.12.M0</version>
+ <version>9.3.12.v20160915</version>
</dependency>
<dependency>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-server</artifactId>
- <version>9.2.12.M0</version>
+ <version>9.3.12.v20160915</version>
</dependency>
<dependency>
```
The benefit of the way that I've coded the configurability bit is that there's a number of new parameters and settings in 9.3 that can be accessed without us needing to change any code to expose them.
Tristan
- Tristan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52955/#review152937
-----------------------------------------------------------
On Oct. 17, 2016, 7:29 p.m., Tristan Stevens wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52955/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2016, 7:29 p.m.)
>
>
> Review request for Flume.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> This patch upgrades the HTTPSource and HTTP Metrics server to Jetty 9.2 (N.B. 9.3/9.4 depend on JDK8). It also adds the ability to further configure the Jetty server and also run in multi-threaded mode.
>
>
> Diffs
> -----
>
> flume-ng-core/pom.xml 2262d94
> flume-ng-core/src/main/java/org/apache/flume/instrumentation/MonitoringType.java 4e1a28c
> flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 921a1f7
> flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java 38bdfda
> flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java 86caf7d
> flume-ng-core/src/main/java/org/apache/flume/tools/FlumeBeanConfigurator.java PRE-CREATION
> flume-ng-core/src/main/java/org/apache/flume/tools/HTTPServerConstraintUtil.java 479cfc4
> flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java 09d419f
> flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java 475d92f
> flume-ng-core/src/test/java/org/apache/flume/source/http/TestBLOBHandler.java f770d51
> flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 3ad8282
> flume-ng-legacy-sources/flume-avro-source/pom.xml 7cecde2
> flume-ng-legacy-sources/flume-thrift-source/pom.xml 1ceeb5b
> flume-ng-sources/flume-scribe-source/pom.xml 73641df
> pom.xml f62c99a
>
> Diff: https://reviews.apache.org/r/52955/diff/
>
>
> Testing
> -------
>
> Passes existing unit tests, further tests to follow.
>
>
> Thanks,
>
> Tristan Stevens
>
>
Re: Review Request 52955: FLUME-2698 - Upgrade Jetty Version
Posted by Lior Zeno <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52955/#review152937
-----------------------------------------------------------
Thanks for your contribution!
There is an open ticket for bumping java version to 8. Will your patch change much if we upgrade to the latest Jetty version?
- Lior Zeno
On Oct. 17, 2016, 7:29 p.m., Tristan Stevens wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52955/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2016, 7:29 p.m.)
>
>
> Review request for Flume.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> This patch upgrades the HTTPSource and HTTP Metrics server to Jetty 9.2 (N.B. 9.3/9.4 depend on JDK8). It also adds the ability to further configure the Jetty server and also run in multi-threaded mode.
>
>
> Diffs
> -----
>
> flume-ng-core/pom.xml 2262d94
> flume-ng-core/src/main/java/org/apache/flume/instrumentation/MonitoringType.java 4e1a28c
> flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 921a1f7
> flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java 38bdfda
> flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java 86caf7d
> flume-ng-core/src/main/java/org/apache/flume/tools/FlumeBeanConfigurator.java PRE-CREATION
> flume-ng-core/src/main/java/org/apache/flume/tools/HTTPServerConstraintUtil.java 479cfc4
> flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java 09d419f
> flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java 475d92f
> flume-ng-core/src/test/java/org/apache/flume/source/http/TestBLOBHandler.java f770d51
> flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 3ad8282
> flume-ng-legacy-sources/flume-avro-source/pom.xml 7cecde2
> flume-ng-legacy-sources/flume-thrift-source/pom.xml 1ceeb5b
> flume-ng-sources/flume-scribe-source/pom.xml 73641df
> pom.xml f62c99a
>
> Diff: https://reviews.apache.org/r/52955/diff/
>
>
> Testing
> -------
>
> Passes existing unit tests, further tests to follow.
>
>
> Thanks,
>
> Tristan Stevens
>
>