You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/08 07:10:05 UTC
[GitHub] [nifi] KuKuDeCheng opened a new pull request #4393: NIFI-7606:Provide "NIFI_HOME()" function in Expression Language to ob…
KuKuDeCheng opened a new pull request #4393:
URL: https://github.com/apache/nifi/pull/4393
NIFI-7606:Provide "NIFI_HOME()" function in Expression Language to obtain the installation directory of NIFI
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
Usually, I make a file '$NIFI_HOME/jdbc' to hold some jars of drivers. I find it's useful to provide a function to get the installation directory of NIFI, and we will use this such as `${NIFI_HOME():append('/jdbc/ojdbc8.jar')}` in `DbcpConnectionPoll` property. I think it will be useful for other scenes need to indicate file directory.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [√ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] KuKuDeCheng commented on pull request #4393: NIFI-7606:Provide "NIFI_HOME()" function in Expression Language to ob…
Posted by GitBox <gi...@apache.org>.
KuKuDeCheng commented on pull request #4393:
URL: https://github.com/apache/nifi/pull/4393#issuecomment-655846568
> Thanks, but we can't accept contributions like this without test coverage. Once you add that we can proceed with a review.
@MikeThomsen I find that it's not necessary. Thank you very much for review and I will close this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] KuKuDeCheng closed pull request #4393: NIFI-7606:Provide "NIFI_HOME()" function in Expression Language to ob…
Posted by GitBox <gi...@apache.org>.
KuKuDeCheng closed pull request #4393:
URL: https://github.com/apache/nifi/pull/4393
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] KuKuDeCheng commented on pull request #4393: NIFI-7606:Provide "NIFI_HOME()" function in Expression Language to ob…
Posted by GitBox <gi...@apache.org>.
KuKuDeCheng commented on pull request #4393:
URL: https://github.com/apache/nifi/pull/4393#issuecomment-655845996
> I don't think this function is necessary. It's simply exposing an environment variable, but all environment variables already are available via Expression Language. You can simply use `${NIFI_HOME}`
@markap14 It's useful!Thank you very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4393: NIFI-7606:Provide "NIFI_HOME()" function in Expression Language to ob…
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4393:
URL: https://github.com/apache/nifi/pull/4393#issuecomment-655526041
I don't think this function is necessary. It's simply exposing an environment variable, but all environment variables already are available via Expression Language. You can simply use `${NIFI_HOME}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org