Re: [PR] fix: when only `tls.verify`, skip the logic of judging client cert [apisix]

["bzp2010 (via GitHub)" <gi...@apache.org>]

bzp2010 commented on code in PR #12527:
URL: https://github.com/apache/apisix/pull/12527#discussion_r2291042738


##########
apisix/upstream.lua:
##########
@@ -261,8 +261,8 @@ function _M.set_by_route(route, api_ctx)
     local checker = healthcheck_manager.fetch_checker(up_conf.resource_key, resource_version)
     api_ctx.up_checker = checker
     local scheme = up_conf.scheme
-    if (scheme == "https" or scheme == "grpcs") and up_conf.tls then
-
+    local tls_has_cert = up_conf.tls and (up_conf.tls.client_cert or up_conf.tls.client_cert_id)

Review Comment:
   Just to confirm, jsonschema will ensure that if cert exists, key must also exist right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org