You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/09/07 09:09:01 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #4594: Support projects without build.gradle
sdedic opened a new pull request, #4594:
URL: https://github.com/apache/netbeans/pull/4594
A multiproject build looks, [according to the documentation](https://docs.gradle.org/current/userguide/multi_project_builds.html#sec:creating_multi_project_builds) like
```
├── app
│ ...
│ └── build.gradle
└── settings.gradle
```
there's no `build.gradle` in the root. While `isSubProject` already works OK with build-less projects, the `isRootProject` does not. This PR fixes that. Simple test added.
During other work, I've realized that the `ProjectFactory2` implementation for both Gradle and Maven do not return project type -- although they could. The display name is not that easy to evaluate, but both project types use a fixed ID, so it's simple to return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #4594: Support projects without build.gradle
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #4594:
URL: https://github.com/apache/netbeans/pull/4594#issuecomment-1239599137
Yes the project ID-s are not really used in NetBeans, a few Ant based projects uses that ID, but that's all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #4594: Support projects without build.gradle
Posted by GitBox <gi...@apache.org>.
sdedic merged PR #4594:
URL: https://github.com/apache/netbeans/pull/4594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #4594: Support projects without build.gradle
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #4594:
URL: https://github.com/apache/netbeans/pull/4594#issuecomment-1239656082
Yes; but for certain purposes it may be important to differentiate the build system, i.e. for some abstractions that map to different actions/goals/properties/whatever in each build system. It was already in the APIs, so I've just filled the gap.
It's a pity that `displayName` remains unfilled - the `isProject2` could be a good query for e.g. file selector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists