You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ajay Yadava <aj...@gmail.com> on 2015/08/13 19:57:12 UTC
Review Request 37441: Property for default number of results is not
loaded dynamically
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37441/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1399
https://issues.apache.org/jira/browse/FALCON-1399
Repository: falcon-git
Description
-------
Currently the property webservices.default.results.per.page is in runtime.properties. Properties in runtime.properties are supposed to be loaded dynamically, however chaning this property doesn't reflect it as the code reads it once and uses the initial value forever.
Diffs
-----
common/src/main/resources/runtime.properties 2159e1a
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 43461c8
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java b382f95
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 465a636
prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java b49d6f8
src/conf/runtime.properties 4d3088b
webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java cbc936e
webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 9a3d6be
Diff: https://reviews.apache.org/r/37441/diff/
Testing
-------
Thanks,
Ajay Yadava
Re: Review Request 37441: Property for default number of results is
not loaded dynamically
Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37441/#review95313
-----------------------------------------------------------
Ship it!
LGTM
- sandeep samudrala
On Aug. 13, 2015, 5:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37441/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 5:57 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1399
> https://issues.apache.org/jira/browse/FALCON-1399
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently the property webservices.default.results.per.page is in runtime.properties. Properties in runtime.properties are supposed to be loaded dynamically, however chaning this property doesn't reflect it as the code reads it once and uses the initial value forever.
>
>
> Diffs
> -----
>
> common/src/main/resources/runtime.properties 2159e1a
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 43461c8
> prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java b382f95
> prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 465a636
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java b49d6f8
> src/conf/runtime.properties 4d3088b
> webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java cbc936e
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 9a3d6be
>
> Diff: https://reviews.apache.org/r/37441/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 37441: Property for default number of results is
not loaded dynamically
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37441/#review95397
-----------------------------------------------------------
Ship it!
Ship It!
- Pallavi Rao
On Aug. 14, 2015, 7:05 a.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37441/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2015, 7:05 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1399
> https://issues.apache.org/jira/browse/FALCON-1399
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently the property webservices.default.results.per.page is in runtime.properties. Properties in runtime.properties are supposed to be loaded dynamically, however chaning this property doesn't reflect it as the code reads it once and uses the initial value forever.
>
>
> Diffs
> -----
>
> common/src/main/resources/runtime.properties f0253e6
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java ff5dc04
> prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java b382f95
> prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 465a636
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java b49d6f8
> src/conf/runtime.properties 1eb3f1c
> webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java cbc936e
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 9a3d6be
>
> Diff: https://reviews.apache.org/r/37441/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 37441: Property for default number of results is
not loaded dynamically
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37441/
-----------------------------------------------------------
(Updated Aug. 14, 2015, 7:05 a.m.)
Review request for Falcon.
Changes
-------
Rebased the patch.
Bugs: FALCON-1399
https://issues.apache.org/jira/browse/FALCON-1399
Repository: falcon-git
Description
-------
Currently the property webservices.default.results.per.page is in runtime.properties. Properties in runtime.properties are supposed to be loaded dynamically, however chaning this property doesn't reflect it as the code reads it once and uses the initial value forever.
Diffs (updated)
-----
common/src/main/resources/runtime.properties f0253e6
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java ff5dc04
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java b382f95
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 465a636
prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java b49d6f8
src/conf/runtime.properties 1eb3f1c
webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java cbc936e
webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 9a3d6be
Diff: https://reviews.apache.org/r/37441/diff/
Testing
-------
Thanks,
Ajay Yadava
Re: Review Request 37441: Property for default number of results is
not loaded dynamically
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37441/#review95387
-----------------------------------------------------------
common/src/main/resources/runtime.properties (line 26)
<https://reviews.apache.org/r/37441/#comment150334>
This was supposed to be in the next line. :)
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 106)
<https://reviews.apache.org/r/37441/#comment150335>
Yes and that caused side effects in instance apis where this is undesirable.
src/conf/runtime.properties (line 35)
<https://reviews.apache.org/r/37441/#comment150336>
Addressed above.
- Ajay Yadava
On Aug. 13, 2015, 5:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37441/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 5:57 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1399
> https://issues.apache.org/jira/browse/FALCON-1399
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently the property webservices.default.results.per.page is in runtime.properties. Properties in runtime.properties are supposed to be loaded dynamically, however chaning this property doesn't reflect it as the code reads it once and uses the initial value forever.
>
>
> Diffs
> -----
>
> common/src/main/resources/runtime.properties 2159e1a
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 43461c8
> prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java b382f95
> prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 465a636
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java b49d6f8
> src/conf/runtime.properties 4d3088b
> webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java cbc936e
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 9a3d6be
>
> Diff: https://reviews.apache.org/r/37441/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 37441: Property for default number of results is
not loaded dynamically
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37441/#review95381
-----------------------------------------------------------
common/src/main/resources/runtime.properties (line 26)
<https://reviews.apache.org/r/37441/#comment150328>
I thought this was going away in another patch. Why change this?
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 106)
<https://reviews.apache.org/r/37441/#comment150329>
Wasn't this intentionally kept a high value for backward compatibility?
src/conf/runtime.properties (line 35)
<https://reviews.apache.org/r/37441/#comment150330>
Wasn't this kept at a high value for backward compatibility?
- Pallavi Rao
On Aug. 13, 2015, 5:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37441/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 5:57 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1399
> https://issues.apache.org/jira/browse/FALCON-1399
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently the property webservices.default.results.per.page is in runtime.properties. Properties in runtime.properties are supposed to be loaded dynamically, however chaning this property doesn't reflect it as the code reads it once and uses the initial value forever.
>
>
> Diffs
> -----
>
> common/src/main/resources/runtime.properties 2159e1a
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 43461c8
> prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java b382f95
> prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 465a636
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java b49d6f8
> src/conf/runtime.properties 4d3088b
> webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java cbc936e
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 9a3d6be
>
> Diff: https://reviews.apache.org/r/37441/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>