You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by nonsleepr <gi...@git.apache.org> on 2017/05/26 19:09:26 UTC
[GitHub] spark pull request #18124: [SPARK-20900][YARN] Catch IllegalArgumentExceptio...
GitHub user nonsleepr opened a pull request:
https://github.com/apache/spark/pull/18124
[SPARK-20900][YARN] Catch IllegalArgumentException thrown by new Path in ApplicationMaster
## What changes were proposed in this pull request?
Catch `IllegalArgumentException` which might be thrown if `SPARK_YARN_STAGING_DIR` is not set or empty.
## How was this patch tested?
Manually tested by running `ApplicationMaster` with `SPARK_YARN_STAGING_DIR` unset.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nonsleepr/spark spark-yarn-staging-dir
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18124.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18124
----
commit fe9d70908150e76d247350a6de8aed6908ca1299
Author: Alexander Bessonov <ab...@bloomberg.net>
Date: 2017-05-26T18:38:36Z
Catch IllegalArgumentException thrown by new Path in ApplicationMaster
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18124: [SPARK-20900][YARN] Catch IllegalArgumentException throw...
Posted by nonsleepr <gi...@git.apache.org>.
Github user nonsleepr commented on the issue:
https://github.com/apache/spark/pull/18124
@srowen Because `Path` will perform multiple checks. E.g. check for `null` or empty string and then URI syntax exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18124: [SPARK-20900][YARN] Catch IllegalArgumentException throw...
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18124
I'm not sure how this could be happened, "SPARK_YARN_STAGING_DIR" is a Spark internal environment variable which should be empty, unless you deliberately unset it.
In the JIRA you mentioned you directly running `ApplicationMaster`, so that you met this issue, I'm not sure why you need to directly call `ApplicationMaster`?
BTW seems you submitted a PR against branch 2.1, why not against master branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18124: [SPARK-20900][YARN] Catch IllegalArgumentExceptio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18124: [SPARK-20900][YARN] Catch IllegalArgumentException throw...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18124
Why? instead of check the value of the env variable directly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18124: [SPARK-20900][YARN] Catch IllegalArgumentException throw...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18124
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18124: [SPARK-20900][YARN] Catch IllegalArgumentException throw...
Posted by nonsleepr <gi...@git.apache.org>.
Github user nonsleepr commented on the issue:
https://github.com/apache/spark/pull/18124
@jerryshao You're right, it won't be empty if I run the app using spark-submit. The whole reason I encountered this bug is that in my project I'm running Spark job remotely (via YARN's REST API) from the node which doesn't have Spark distro.
My motivation for running it is another story but in short: I don't want to upload my keytab to HDFS to run spark-submit and instead I request delegation tokens for the services my job uses.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18124: [SPARK-20900][YARN] Catch IllegalArgumentException throw...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18124
I don't think we'd change this then if it's kind of complicating the code and for a non-standard usage anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org