You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-dev@hadoop.apache.org by Nigel Daley <nd...@yahoo-inc.com> on 2007/05/22 07:28:31 UTC

Findbugs Jira comment

> Hadoop QA commented on HADOOP-894:
> ----------------------------------
>
> +0
>
> http://issues.apache.org/jira/secure/attachment/12357807/ 
> partialBlockList5.patch applied and successfully tested against  
> trunk revision r540271,
> but there appear to be new Findbugs warnings introduced by this patch.
>
> Findbugs output: http://lucene.zones.apache.org:8080/hudson/job/ 
> Hadoop-Patch/171/artifact/trunk/build/test/findbugs/ 
> newPatchFindbugsWarnings.html
> Test results:    http://lucene.zones.apache.org:8080/hudson/job/ 
> Hadoop-Patch/171/testReport/
> Console output:  http://lucene.zones.apache.org:8080/hudson/job/ 
> Hadoop-Patch/171/console

I'm inclined to make the Findbugs comment a -1 instead of a +0. Also,  
I'll try to make the message clearer.

Thoughts?

Cheers,
Nige

Re: Findbugs Jira comment

Posted by Owen O'Malley <oo...@yahoo-inc.com>.

On May 21, 2007, at 10:28 PM, Nigel Daley wrote:

> I'm inclined to make the Findbugs comment a -1 instead of a +0.  
> Also, I'll try to make the message clearer.

I think that a +0 is better until we finalize on a set of rules that  
should be enforced.

-- Owen