You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2021/06/15 09:23:18 UTC

[GitHub] [jackrabbit] pdenooijer opened a new pull request #93: JCR-3928: Add pathStyleAccess flag

pdenooijer opened a new pull request #93:
URL: https://github.com/apache/jackrabbit/pull/93


   Based on #47 but without the deprecations and lots of random commits.
   
   This will resolve [JCR-3928](https://issues.apache.org/jira/browse/JCR-3928).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit] pdenooijer edited a comment on pull request #93: JCR-3928: Add pathStyleAccess flag

Posted by GitBox <gi...@apache.org>.
pdenooijer edited a comment on pull request #93:
URL: https://github.com/apache/jackrabbit/pull/93#issuecomment-867387449


   Thanks for the quick reply!
   
   Back on topic: it won't be easy to unit test in the current setup, as the addition basically just proxies a setting to the `AmazonS3Client` class. As this is a dependency that is hard coded in the static Util class, it's not easy to mock/replace/etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit] pdenooijer commented on pull request #93: JCR-3928: Add pathStyleAccess flag

Posted by GitBox <gi...@apache.org>.
pdenooijer commented on pull request #93:
URL: https://github.com/apache/jackrabbit/pull/93#issuecomment-867387449


   It won't be easy to unit test in the current test setup, as the addition basically just proxies a setting to the `AmazonS3Client` class. As this is a dependency that is hard coded, it's not easy to mock.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit] pdenooijer commented on pull request #93: JCR-3928: Add pathStyleAccess flag

Posted by GitBox <gi...@apache.org>.
pdenooijer commented on pull request #93:
URL: https://github.com/apache/jackrabbit/pull/93#issuecomment-867417864


   See you committed it, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit] pdenooijer closed pull request #93: JCR-3928: Add pathStyleAccess flag

Posted by GitBox <gi...@apache.org>.
pdenooijer closed pull request #93:
URL: https://github.com/apache/jackrabbit/pull/93


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit] pdenooijer edited a comment on pull request #93: JCR-3928: Add pathStyleAccess flag

Posted by GitBox <gi...@apache.org>.
pdenooijer edited a comment on pull request #93:
URL: https://github.com/apache/jackrabbit/pull/93#issuecomment-867387449






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit] pdenooijer commented on pull request #93: JCR-3928: Add pathStyleAccess flag

Posted by GitBox <gi...@apache.org>.
pdenooijer commented on pull request #93:
URL: https://github.com/apache/jackrabbit/pull/93#issuecomment-866823529


   @reschke is there any change this gets merged? It would help out our project immensely as there would be no need to support a patched jackrabbit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit] pdenooijer edited a comment on pull request #93: JCR-3928: Add pathStyleAccess flag

Posted by GitBox <gi...@apache.org>.
pdenooijer edited a comment on pull request #93:
URL: https://github.com/apache/jackrabbit/pull/93#issuecomment-867417864


   See you committed it, thanks! See 426b4c2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit] reschke commented on pull request #93: JCR-3928: Add pathStyleAccess flag

Posted by GitBox <gi...@apache.org>.
reschke commented on pull request #93:
URL: https://github.com/apache/jackrabbit/pull/93#issuecomment-867063709


   Of course.
   
   I guess a unit test for this is hard to do?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org