You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2017/08/10 17:29:35 UTC
Re: Review Request 60088: CLI: Added 'master' key as an acceptable
key in config.toml.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60088/#review182611
-----------------------------------------------------------
src/python/cli_new/README.md
Lines 81 (patched)
<https://reviews.apache.org/r/60088/#comment258573>
Can we make this a list of masters instead of a single master?
- Kevin Klues
On July 28, 2017, 12:54 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60088/
> -----------------------------------------------------------
>
> (Updated July 28, 2017, 12:54 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7284
> https://issues.apache.org/jira/browse/MESOS-7284
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This key is a dictionnary that includes two keys: 'ip' and 'port'.
> It will be used by future plugins.
>
>
> Diffs
> -----
>
> src/python/cli_new/README.md c5475c7f4632fde5303ed1c901918d9088eac660
> src/python/cli_new/lib/cli/config.py 36a32f94bb12a033705b20f3c91d8bba972ba6c5
>
>
> Diff: https://reviews.apache.org/r/60088/diff/3/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
>
>
> Thanks,
>
> Armand Grillet
>
>