You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "arshilkxwork (via GitHub)" <gi...@apache.org> on 2026/10/19 19:27:17 UTC

[PR] fix(build): sign and attach release artifacts once [hugegraph-toolchain]

arshilkxwork opened a new pull request, #828:
URL: https://github.com/apache/hugegraph-toolchain/pull/828

   ## Purpose of the PR
   
   - close #821
   
   Under `-Papache-release`, Maven merges this repository's release settings with the `apache-release` profile of Apache parent 23. Three local executions used ids or goals that differ from the parent's, so both copies ran:
   
   - Root and Loader declared `sign-artifacts` next to the parent's `sign-release-artifacts`. Every module ran `gpg:sign` twice, and the second run also signed the first run's signatures.
   - Tools declared `create-source-jar` and `create-javadoc-jar` next to the inherited `attach-sources` and `attach-javadocs`, so its sources and Javadoc jars were built twice.
   - Spark's `attach-sources` runs `jar` and the parent's runs `jar-no-fork`, and the merged execution ran both.
   
   On master, a smoke deploy of root, client, Loader, Spark connector and Tools to a local file repository, signed with a throwaway key, produced 40 signatures, 20 of them `.asc.asc` files, and 23 "already attached, replace previous instance" warnings.
   
   ## Main Changes
   
   - Root `pom.xml` and Loader: the signing execution uses the parent's id, `sign-release-artifacts`, so the two merge into one. The `--pinentry-mode loopback` arguments are unchanged.
   - Tools: `create-source-jar` becomes `attach-sources` with `jar-no-fork` and `test-jar-no-fork`, which keeps the test sources jar, and `create-javadoc-jar` becomes `attach-javadocs` with `jar`. The `javadoc` goal, which only wrote the HTML report under `target/site`, is dropped. The `<source>` setting stays.
   - Spark: `attach-sources` uses the parent's `jar-no-fork`. Outside the release profile it still attaches the sources jar, without forking the lifecycle.
   - `.github/scripts/test_release_profile.py` runs `help:effective-pom -Papache-release` over the whole reactor and checks each module for one `gpg:sign` execution, one sources-jar producer using one of `jar` or `jar-no-fork`, one Javadoc-jar producer, and, for Tools, the test sources jar. Like `test_candidate_sdk.py` it is opt-in, through `RELEASE_PROFILE_MAVEN_TEST`, and a new `ci.yml` step runs it with Java 17 after the Java setup.
   
   No dependency or plugin version changes.
   
   The source archive still contains `.github`, `.serena`, `.goal-task` and the generated `.flattened-pom.xml`, as it does on master, because the Apache source-release descriptor does not exclude them. That is left out of this change.
   
   ## Verifying these changes
   
   - [ ] Trivial rework / code cleanup without any test coverage. (No Need)
   - [ ] Already covered by existing tests, such as *(please modify tests here)*.
   - [x] Need tests and can be verified as follows:
       - `RELEASE_PROFILE_MAVEN_TEST=mvn python3 -m unittest discover -s .github/scripts -p 'test_release_profile.py'` on Java 17 passes. On master it fails for all 9 modules, with two `gpg:sign` executions in each.
       - Effective POM before and after: the plugin-level configuration of the gpg, source and Javadoc plugins is the same in every module.
       - Release smoke test with a temporary GPG key: `mvn -Papache-release -DskipTests -pl .,hugegraph-client,hugegraph-tools,hugegraph-spark-connector,hugegraph-loader deploy -DaltDeploymentRepository=smoke::default::file://...`. After the change there are 20 signatures, one per artifact, all passing `gpg --verify`, no `.asc.asc` files and no "already attached" warnings. The deployed files match master's apart from the `.asc.asc` files, and Tools still ships `-tests.jar` and `-test-sources.jar`. The one warning left is the Spark shade plugin replacing the main jar, which master shows as well.
       - The `-source-release.zip` from that run contains no `.git`. Extracted with `.github` removed, it builds the same five modules with `mvn -DskipTests package`.
       - `python3 -m unittest discover -s .github/scripts -p 'test_*.py'`: 97 tests, 5 skipped.
       - Not covered: Hubble was not in the smoke deploy, since it needs the frontend build; its modules show the same single executions in the effective POM. No real Apache staging deploy was run.
   
   ## Does this PR potentially affect the following parts?
   
   - [ ]  Nope
   - [ ]  Dependencies (add/update license info)
   - [ ]  Modify configurations
   - [ ]  The public API
   - [x]  Other affects (typed here): the `apache-release` Maven profile used to build and sign releases
   
   ## Documentation Status
   
   - [ ]  `Doc - TODO`
   - [ ]  `Doc - Done`
   - [x]  `Doc - No Need`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(build): sign and attach release artifacts once [hugegraph-toolchain]

Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #828:
URL: https://github.com/apache/hugegraph-toolchain/pull/828


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(build): sign and attach release artifacts once [hugegraph-toolchain]

Posted by "arshilkxwork (via GitHub)" <gi...@apache.org>.
arshilkxwork commented on PR #828:
URL: https://github.com/apache/hugegraph-toolchain/pull/828#issuecomment-6284910817

   Thanks for the review. Added in 597d036d: `test_release_profile.py` now counts the source-plugin executions with a `test-jar` or `test-jar-no-fork` goal, expecting one for Tools and none elsewhere, each with a single such goal. It catches the case you describe: with an extra `test-jar` execution added to the Tools POM it fails with `1 != 2 : test source jar producers`, and it passes on this branch.
   
   Artifact-level smoke evidence, from `mvn -B -ntp -Papache-release -DskipTests -pl .,hugegraph-client,hugegraph-tools,hugegraph-spark-connector,hugegraph-loader deploy -DaltDeploymentRepository=smoke::default::file://<dir>` on Java 17 and Maven 3.10.0, signed with a temporary RSA 2048 key (GnuPG 2.5). This PR's run used the POMs of 2f55194, which 597d036d does not change; the master run used 431b45b3.
   
   | Module | Artifacts | `.asc`, this PR | `.asc.asc`, this PR | `.asc.asc`, master |
   |---|---:|---:|---:|---:|
   | hugegraph-toolchain (pom, source-release zip) | 2 | 2 | 0 | 2 |
   | hugegraph-client | 4 | 4 | 0 | 4 |
   | hugegraph-loader | 4 | 4 | 0 | 4 |
   | hugegraph-spark-connector | 4 | 4 | 0 | 4 |
   | hugegraph-tools | 6 | 6 | 0 | 6 |
   
   Artifacts are counted without signatures, checksums and metadata: pom, jar, sources and javadoc for client, Loader and Spark, plus `-tests.jar` and `-test-sources.jar` for Tools.
   
   - All 20 signatures from this PR's run passed `gpg --verify` against their artifacts. The temporary key was deleted afterwards, so I can't re-verify those files now.
   - "already attached, replace previous instance" warnings: 23 on master, none on this PR. The one warning left on both is the Spark shade plugin replacing the main jar.
   - Apart from the `.asc.asc` files, both runs deployed the same file names.
   - The source-release zip from this PR's run contains no `.git`. Extracted with `.github` removed, `mvn -B -ntp -DskipTests package -pl .,hugegraph-client,hugegraph-tools,hugegraph-spark-connector,hugegraph-loader` succeeds.
   
   Hubble was not part of this run, and no Apache staging deploy was done.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] fix(build): sign and attach release artifacts once [hugegraph-toolchain]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #828:
URL: https://github.com/apache/hugegraph-toolchain/pull/828#issuecomment-6283883450

   ## [Codecov](https://app.codecov.io/gh/apache/hugegraph-toolchain/pull/828?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 58.73%. Comparing base ([`411aca3`](https://app.codecov.io/gh/apache/hugegraph-toolchain/commit/411aca3389dd610d9a4f3b3595f06a53ee67e2ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2f55194`](https://app.codecov.io/gh/apache/hugegraph-toolchain/commit/2f55194ed46034dba5657f36ba8302a60a3b39b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #828      +/-   ##
   ============================================
   + Coverage     51.79%   58.73%   +6.94%     
   + Complexity     5309     1226    -4083     
   ============================================
     Files           619      111     -508     
     Lines         31606     6330   -25276     
     Branches       3945      858    -3087     
   ============================================
   - Hits          16370     3718   -12652     
   + Misses        13750     2353   -11397     
   + Partials       1486      259    -1227     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/hugegraph-toolchain/pull/828?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org