[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #926: IGNITE-17281 Added support error codes and trace ids to rest components

[GitBox <gi...@apache.org>]

PakhomovAlexander commented on code in PR #926:
URL: https://github.com/apache/ignite-3/pull/926#discussion_r915713804


##########
modules/rest-api/src/test/java/org/apache/ignite/internal/rest/exception/handler/IgniteExceptionHandlerTest.java:
##########
@@ -64,7 +68,7 @@ static Stream<Arguments> igniteExceptions() {
                         Problem.builder()
                                 .status(500)
                                 .title("Internal Server Error")
-                                .code(UNKNOWN_ERR)
+                                .code(humanReadableCode)
                                 .detail(errorMessage + " Ooops")

Review Comment:
   As far as I can see, `errorMessage` contains `traceId` and a human-readable code.  But this information is already included in the problem json. Shall we duplicate the information in the API response? WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org