[GitHub] [couchdb] nickva commented on issue #2464: Port etags tests into elixir test suite

[GitBox <gi...@apache.org>]

nickva commented on issue #2464: Port etags tests into elixir test suite
URL: https://github.com/apache/couchdb/pull/2464#issuecomment-575841827
 
 
   @jjrodrig thank you for your contribution
   
   Test looks good. I added two small fixes to it:
   
   ```
   diff --git a/test/elixir/lib/couch.ex b/test/elixir/lib/couch.ex
   index 994b68173..3aef07f01 100644
   --- a/test/elixir/lib/couch.ex
   +++ b/test/elixir/lib/couch.ex
   @@ -110,7 +110,7 @@ defmodule Couch do
        end
      end
   
   -  def process_response_body(headers, body) when body == [] do
   +  def process_response_body(_headers, body) when body == [] do
        ""
      end
   
   diff --git a/test/javascript/tests/etags_head.js b/test/javascript/tests/etags_head.js
   index 9faca4af6..6cb99e40d 100644
   --- a/test/javascript/tests/etags_head.js
   +++ b/test/javascript/tests/etags_head.js
   @@ -11,6 +11,7 @@
    // the License.
   
    couchTests.etags_head = function(debug) {
   +  return console.log('done in tests=test/elixir/test/etags_head_test.exs');
      var db_name = get_random_db_name();
      var db = new CouchDB(db_name, {"X-Couch-Full-Commit":"false"});
      db.createDb();
   ```
   
   Then squashed them into one commit and pushed them to the new PR https://github.com/apache/couchdb/pull/2469
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services