You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/03 05:22:27 UTC
[GitHub] [helix] pkuwm opened a new issue #1343: Unnecessary getChildren call in subscribeForChanges
pkuwm opened a new issue #1343:
URL: https://github.com/apache/helix/issues/1343
In CallbackHanlder's `subscribeForChanges()`, children names need to be fetched. `subscribeChildChange(path, callbackType)` does actually have the children list, but it doesn't return, and later `getChildren()` is called again. It wastes one zk call: not only wasting time in handling a callback, but also adds more read pressure to zk server.
We could use the return result from subscribeChildChange() and save one `getChildren()` call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm closed issue #1343: Unnecessary getChildren call in subscribeForChanges
Posted by GitBox <gi...@apache.org>.
pkuwm closed issue #1343:
URL: https://github.com/apache/helix/issues/1343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm closed issue #1343: Unnecessary getChildren call in subscribeForChanges
Posted by GitBox <gi...@apache.org>.
pkuwm closed issue #1343:
URL: https://github.com/apache/helix/issues/1343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org