You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2021/07/26 15:35:30 UTC

[GitHub] [incubator-teaclave-sgx-sdk] PiDelport opened a new pull request #347: Clean up project template

PiDelport opened a new pull request #347:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/347


   * Fix spelling / typos
   * Avoid hardcoding `SGX_SDK`, so that it can be overridden from the environment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org

[GitHub] [incubator-teaclave-sgx-sdk] PiDelport commented on pull request #347: Clean up project template

Posted by GitBox <gi...@apache.org>.
PiDelport commented on pull request #347:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/347#issuecomment-922346367


   Cool, change applied: [92a4b6b..c553179](https://github.com/apache/incubator-teaclave-sgx-sdk/compare/92a4b6b..c553179)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org

[GitHub] [incubator-teaclave-sgx-sdk] mssun commented on pull request #347: Clean up project template

Posted by GitBox <gi...@apache.org>.
mssun commented on pull request #347:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/347#issuecomment-926172107


   Thank you so much! Merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org

[GitHub] [incubator-teaclave-sgx-sdk] mssun merged pull request #347: Clean up project template

Posted by GitBox <gi...@apache.org>.
mssun merged pull request #347:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/347


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org

[GitHub] [incubator-teaclave-sgx-sdk] mssun commented on a change in pull request #347: Clean up project template

Posted by GitBox <gi...@apache.org>.
mssun commented on a change in pull request #347:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/347#discussion_r707655665



##########
File path: samplecode/project_template/README.md
##########
@@ -1,7 +1,7 @@
 # Rust SGX - Template project
 ==================================
 
-### This is a template project to start developing with the Teaenclave Rust SGX SDK (https://github.com/apache/incubator-teaclave-sgx-sdk/) easily.
+### This is a template project to start developing with the Teaclave Rust SGX SDK (https://github.com/apache/incubator-teaclave-sgx-sdk/) easily.

Review comment:
       We call it Teaclave SGX SDK or Rust SGX SDK.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org