You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/05 10:26:29 UTC
[GitHub] [airflow] ashb opened a new pull request #15667: Auto-apply apply_default decorator
ashb opened a new pull request #15667:
URL: https://github.com/apache/airflow/pull/15667
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #15667: Auto-apply apply_default decorator
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #15667:
URL: https://github.com/apache/airflow/pull/15667#issuecomment-832665823
Yeah. If it's 'days' then we can do option 2) cut the branch where we can cherry-pick any provider changes where we could relase providers from by cherry-picking if needed - just before merging this one, and yeah, in this case we can disable the "2.0" build and enable it back pointing to 2.1.0 right after the rc1 for 2.1.0 gets released. We'd then have to add `>=2.1.0rc1` for all priovider -> airflow dependencies.
but I think it would be OK to do it when we are sure rc1 is going to be released "shortly" :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15667: Auto-apply apply_default decorator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15667:
URL: https://github.com/apache/airflow/pull/15667#issuecomment-833656378
[The Workflow run](https://github.com/apache/airflow/actions/runs/817441609) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15667: Auto-apply apply_default decorator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15667:
URL: https://github.com/apache/airflow/pull/15667#issuecomment-832590214
[The Workflow run](https://github.com/apache/airflow/actions/runs/813082318) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #15667: Auto-apply apply_default decorator
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #15667:
URL: https://github.com/apache/airflow/pull/15667#issuecomment-834330023
@potiuk Happy to merge this now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15667: Auto-apply apply_default decorator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15667:
URL: https://github.com/apache/airflow/pull/15667#issuecomment-833628157
[The Workflow run](https://github.com/apache/airflow/actions/runs/817393627) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15667: Auto-apply apply_default decorator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15667:
URL: https://github.com/apache/airflow/pull/15667#issuecomment-834335838
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #15667: Auto-apply apply_default decorator
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #15667:
URL: https://github.com/apache/airflow/pull/15667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #15667: Auto-apply apply_default decorator
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #15667:
URL: https://github.com/apache/airflow/pull/15667#issuecomment-832636549
That's _why_ I'm picking that this now, as it's what we are days away 2.1 release, and I was thinking that the small window of not being able to release providers was okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15667: Auto-apply apply_default decorator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15667:
URL: https://github.com/apache/airflow/pull/15667#issuecomment-832618661
[The Workflow run](https://github.com/apache/airflow/actions/runs/813201394) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15667: Auto-apply apply_default decorator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15667:
URL: https://github.com/apache/airflow/pull/15667#issuecomment-832590470
[The Workflow run](https://github.com/apache/airflow/actions/runs/813117646) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15667: Auto-apply apply_default decorator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15667:
URL: https://github.com/apache/airflow/pull/15667#issuecomment-832602385
[The Workflow run](https://github.com/apache/airflow/actions/runs/813136830) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15667: Auto-apply apply_default decorator
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15667:
URL: https://github.com/apache/airflow/pull/15667#issuecomment-832665823
Yeah. If it's 'days' then we can do option 2) cut the branch where we can cherry-pick any provider changes where we could relase providers from by cherry-picking if needed - just before merging this one, and yeah, in this case we can disable the "2.0" build and enable it back pointing to 2.1.0 right after the rc1 for 2.1.0 gets released. We'd then have to add `>=2.1.0rc1` for all priovider -> airflow dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15667: Auto-apply apply_default decorator
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15667:
URL: https://github.com/apache/airflow/pull/15667#issuecomment-834334552
Absolutely. I will branch-off any changes in providers in case we need to release them with 2.0 compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org