You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Pedro Santos (JIRA)" <ji...@apache.org> on 2011/01/04 21:05:52 UTC
[jira] Created: (WICKET-3308) Turn the
FormComponent#getConvertedValue method to protected
Turn the FormComponent#getConvertedValue method to protected
------------------------------------------------------------
Key: WICKET-3308
URL: https://issues.apache.org/jira/browse/WICKET-3308
Project: Wicket
Issue Type: Improvement
Affects Versions: 1.5-M3
Reporter: Pedro Santos
Priority: Trivial
Pasting a message from the irc:
"whats the "right" way of retreiving values from a simple formcomponent such as textfield<String>: youve got getModel, getValue, getInput, getConvertedValue, ......."
getConvertedValue is mainly used by updateModel and FormComponent subclasses, an protected access modifier would make the API clearer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3308) Turn the
FormComponent#getConvertedInput method to protected
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977762#action_12977762 ]
Pedro Santos commented on WICKET-3308:
--------------------------------------
I missed that compounded component usecase that needs the converted input earlier in the form processing.
I improved the getConvertedInput javadoc a bit, if I didn't missed any thing more we can commit:
/**
* Gets the converted input. The converted input is set earlier though the implementation of
* {@link #convertInput()}.
*
* This method is useful to provide the converted input to {@link FormComponentPanel} components
* compounded by this form component. They may need this converted value to compound their own
* when requested in earlier form process steps like validation.
*
* To access the model object resulted by the full form processing, use
* {@link #getModelObject()} instead, that is an generified version of
* {@link #getDefaultModelObject()}
*
* @return value of input possibly converted into an appropriate type
*/
> Turn the FormComponent#getConvertedInput method to protected
> ------------------------------------------------------------
>
> Key: WICKET-3308
> URL: https://issues.apache.org/jira/browse/WICKET-3308
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.5-M3
> Reporter: Pedro Santos
> Assignee: Igor Vaynberg
> Priority: Trivial
>
> Pasting a message from the irc:
> "whats the "right" way of retreiving values from a simple formcomponent such as textfield<String>: youve got getModel, getValue, getInput, getConvertedValue, ......."
> getConvertedInput is mainly used by updateModel and FormComponent subclasses, an protected access modifier would make the API clearer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3308) Turn the
FormComponent#getConvertedInput method to protected
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3308.
-----------------------------------
Resolution: Invalid
Assignee: Igor Vaynberg
needs to stay public because it is called from outside the component by components that compose their values from multiple form components
> Turn the FormComponent#getConvertedInput method to protected
> ------------------------------------------------------------
>
> Key: WICKET-3308
> URL: https://issues.apache.org/jira/browse/WICKET-3308
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.5-M3
> Reporter: Pedro Santos
> Assignee: Igor Vaynberg
> Priority: Trivial
>
> Pasting a message from the irc:
> "whats the "right" way of retreiving values from a simple formcomponent such as textfield<String>: youve got getModel, getValue, getInput, getConvertedValue, ......."
> getConvertedInput is mainly used by updateModel and FormComponent subclasses, an protected access modifier would make the API clearer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3308) Turn the
FormComponent#getConvertedInput method to protected
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979031#action_12979031 ]
Hudson commented on WICKET-3308:
--------------------------------
Integrated in Apache Wicket 1.4.x #376 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/376/])
> Turn the FormComponent#getConvertedInput method to protected
> ------------------------------------------------------------
>
> Key: WICKET-3308
> URL: https://issues.apache.org/jira/browse/WICKET-3308
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.5-M3
> Reporter: Pedro Santos
> Assignee: Igor Vaynberg
> Priority: Trivial
>
> Pasting a message from the irc:
> "whats the "right" way of retreiving values from a simple formcomponent such as textfield<String>: youve got getModel, getValue, getInput, getConvertedValue, ......."
> getConvertedInput is mainly used by updateModel and FormComponent subclasses, an protected access modifier would make the API clearer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3308) Turn the
FormComponent#getConvertedInput method to protected
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3308:
---------------------------------
Description:
Pasting a message from the irc:
"whats the "right" way of retreiving values from a simple formcomponent such as textfield<String>: youve got getModel, getValue, getInput, getConvertedValue, ......."
getConvertedInput is mainly used by updateModel and FormComponent subclasses, an protected access modifier would make the API clearer
was:
Pasting a message from the irc:
"whats the "right" way of retreiving values from a simple formcomponent such as textfield<String>: youve got getModel, getValue, getInput, getConvertedValue, ......."
getConvertedValue is mainly used by updateModel and FormComponent subclasses, an protected access modifier would make the API clearer
Summary: Turn the FormComponent#getConvertedInput method to protected (was: Turn the FormComponent#getConvertedValue method to protected)
> Turn the FormComponent#getConvertedInput method to protected
> ------------------------------------------------------------
>
> Key: WICKET-3308
> URL: https://issues.apache.org/jira/browse/WICKET-3308
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.5-M3
> Reporter: Pedro Santos
> Priority: Trivial
>
> Pasting a message from the irc:
> "whats the "right" way of retreiving values from a simple formcomponent such as textfield<String>: youve got getModel, getValue, getInput, getConvertedValue, ......."
> getConvertedInput is mainly used by updateModel and FormComponent subclasses, an protected access modifier would make the API clearer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3308) Turn the
FormComponent#getConvertedInput method to protected
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977826#action_12977826 ]
Igor Vaynberg commented on WICKET-3308:
---------------------------------------
i would rephrase that a bit:
FormComponentPanels often access this method when constructing their converted input value which is often the combination of converted values of the embedded FormComponents
> Turn the FormComponent#getConvertedInput method to protected
> ------------------------------------------------------------
>
> Key: WICKET-3308
> URL: https://issues.apache.org/jira/browse/WICKET-3308
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.5-M3
> Reporter: Pedro Santos
> Assignee: Igor Vaynberg
> Priority: Trivial
>
> Pasting a message from the irc:
> "whats the "right" way of retreiving values from a simple formcomponent such as textfield<String>: youve got getModel, getValue, getInput, getConvertedValue, ......."
> getConvertedInput is mainly used by updateModel and FormComponent subclasses, an protected access modifier would make the API clearer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.