You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@issues.apache.org on 2011/03/03 21:34:25 UTC

[Bug 6547] New: Client.pm uses IO::Socket::INET, not IPv6 compatible

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6547

           Summary: Client.pm uses IO::Socket::INET, not IPv6 compatible
           Product: Spamassassin
           Version: 3.3.1
          Platform: PC
        OS/Version: Windows 7
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Libraries
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: mishikal@yahoo.com


The Client.PM module only uses IO::Socket::INET, meaning it will not work with
IPv6 only hosts.  It should be updated to use IO::Socket::INET6 any time it is
available, since that supports both IPv4 and IPv6.

./Mail/SpamAssassin/Client.pm:    $remote = IO::Socket::INET->new( Proto     =>
"tcp",


--Quanah

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6547] Client.pm uses IO::Socket::INET, not IPv6 compatible

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6547

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Mark Martinec <Ma...@ijs.si> 2011-10-04 17:22:21 UTC ---
Closing. Fixed for trunk/3.4.0 .

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6547] Client.pm uses IO::Socket::INET, not IPv6 compatible

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6547

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.4.0

--- Comment #1 from Mark Martinec <Ma...@ijs.si> 2011-09-21 02:17:49 UTC ---
trunk:
  Bug 6547: Client.pm uses IO::Socket::INET, not IPv6 compatible;
  let the spamd -A default include also the ::1 in addition to 127.0.0.1
Sending lib/Mail/SpamAssassin/Client.pm
Sending spamd/spamd.raw
Sending t/SATest.pm
Committed revision 1173462.


test seems to be happy:

# SPAMD_HOST='::1' prove t/spamd_client.t
t/spamd_client.t .. ok
All tests successful.
Files=1, Tests=52, 21 wallclock secs ( 0.04 usr  0.02 sys +  7.04 cusr  0.41
csys =  7.51 CPU)
Result: PASS

# SPAMD_HOST='127.0.0.1' prove t/spamd_client.t
t/spamd_client.t .. ok
All tests successful.
Files=1, Tests=52, 21 wallclock secs ( 0.03 usr  0.02 sys +  7.00 cusr  0.37
csys =  7.41 CPU)
Result: PASS

# prove t/spamd_client.t
t/spamd_client.t .. ok
All tests successful.
Files=1, Tests=52, 21 wallclock secs ( 0.05 usr  0.01 sys +  7.00 cusr  0.38
csys =  7.44 CPU)
Result: PASS

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6547] Client.pm uses IO::Socket::INET, not IPv6 compatible

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6547

--- Comment #2 from Mark Martinec <Ma...@ijs.si> 2011-09-21 02:19:59 UTC ---
Created attachment 4961
  --> https://issues.apache.org/SpamAssassin/attachment.cgi?id=4961
proposed patch

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6547] Client.pm uses IO::Socket::INET, not IPv6 compatible

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6547

--- Comment #4 from Mark Martinec <Ma...@ijs.si> ---
Later changes in DnsResolver.pm and spamd.raw prefer to use
module IO::Socket::IP (if available) over IO::Socket::INET6.
Let Client.pm use the same decision logic.

trunk:
  Bug 6547: let Client.pm use the same logic as DnsResolver.pm in deciding
  which of the IO modules to use (IO::Socket::IP preferred to older
  IO::Socket::INET6, which in turn is preferred to IPv4-only IO::Socket::INET)
Sending lib/Mail/SpamAssassin/Client.pm
Committed revision 1441536.

-- 
You are receiving this mail because:
You are the assignee for the bug.