[jira] [Commented] (SPARK-15015) Log statements lack file name/number

["John-Michael Reed (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-15015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857772#comment-16857772 ] 

John-Michael Reed commented on SPARK-15015:
-------------------------------------------

[~srowen] [~WangTao] [~hyukjin.kwon],

I am just going to go ahead, pull from the master branch, create a JAR file with the modified logger, stick that modified logger in as a dependency to the build, and change the imports so that Spark uses the modified logger with the file name and line numbers which are obtained through Scala macros at compile time with virtually zero runtime overhead. I will test out the new debug logger with the Spark codebase and then I will re-open this issue along with a proposed code change. If any of you has a problem with that, just let me know.

Sincerely,

- John

> Log statements lack file name/number
> ------------------------------------
>
>                 Key: SPARK-15015
>                 URL: https://issues.apache.org/jira/browse/SPARK-15015
>             Project: Spark
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.6.1
>         Environment: All
>            Reporter: John-Michael Reed
>            Priority: Trivial
>              Labels: bulk-closed, debug, log
>
> I would like it if the Apache Spark project had file names and line numbers in its log statements like this:
> http://i.imgur.com/4hvGQ0t.png
> The example uses my library, http://johnreedlol.github.io/scala-trace-debug/, but https://github.com/lihaoyi/sourcecode is also useful for this purpose. 
> The real benefit in doing this is because the user of an IDE can jump to the location of a log statement without having to set breakpoints.
> http://s29.postimg.org/ud0knou1j/debug_Screenshot_Crop.png
> Note that the arrow will go to the next log statement if each log statement is hyperlinked.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org