You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/29 14:27:44 UTC

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

Technoboy- commented on a change in pull request #13383:
URL: https://github.com/apache/pulsar/pull/13383#discussion_r776352072



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java
##########
@@ -1815,13 +1815,13 @@ public void testUnackedBlockAtBatch(int batchMessageDelayMs, boolean ackReceiptE
                     messages.add(msg);
                     totalReceiveMessages++;
                     consumer1.acknowledgeAsync(msg);
-                    log.info("Received message: " + new String(msg.getData()));
                 } else {
                     break;
                 }
             }
             // verify total-consumer messages = total-produce messages
-            assertEquals(totalProducedMsgs, totalReceiveMessages);
+            final int finalTotalReceiveMessages = totalReceiveMessages;
+            Awaitility.await().untilAsserted(() -> assertEquals(totalProducedMsgs, finalTotalReceiveMessages));

Review comment:
       Make a wrong modify. sorry for this. not this class




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org