[GitHub] cloud-fan commented on a change in pull request #23259: [SPARK-26215][SQL] Define reserved/non-reserved keywords based on the ANSI SQL standard

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #23259: [SPARK-26215][SQL] Define reserved/non-reserved keywords based on the ANSI SQL standard
URL: https://github.com/apache/spark/pull/23259#discussion_r257713248
 
 

 ##########
 File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
 ##########
 @@ -719,15 +724,17 @@ qualifiedName
     ;
 
 identifier
-    : strictIdentifier
+    : {ansi}? ansiReserved
+    | strictIdentifier
     | ANTI | FULL | INNER | LEFT | SEMI | RIGHT | NATURAL | JOIN | CROSS | ON
     | UNION | INTERSECT | EXCEPT | SETMINUS
 
 Review comment:
   are these the only reserved keywords before your PR? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org