You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/10 16:48:53 UTC

[GitHub] [shardingsphere] terrymanu opened a new issue, #17537: Add test cases of SPI factories

terrymanu opened a new issue, #17537:
URL: https://github.com/apache/shardingsphere/issues/17537

   The steps of add test case  of SPI factories:
   
   1. Create or reuse a SPI fixture, name as `XXXFixture` in test folder and do not forget put them into META-INF/services;
   2. Add test case for XXXFactory's `newInstance`, `findInstance`, `getInstance`, `getInstances`, `getAllInstances` and so on;
   3.Please reference `ClusterPersistRepositoryFactoryTest` or `ScalingEntryFactoryTest` as samples.
   
   The SPI factories need to be tested are:
   
   - [ ] SQLExecutionUnitBuilderFactory
   - [ ] DatabaseTypeFactory
   - [ ] PipelineDataSourceCreatorFactory
   - [ ] RALUpdaterFactory
   - [ ] SQLVisitorFacadeFactory
   - [ ] OptimizerSQLDialectBuilderFactory
   - [ ] TransactionConfigurationFileGeneratorFactory
   - [ ] PositionInitializerFactory
   - [ ] DialectDDLGenerator
   - [ ] OKProxyStateFactory
   - [ ] PipelineSQLBuilderFactory
   - [ ] DriverStateFactory
   - [ ] PersistRepositoryConfigurationYamlSwapperFactory
   - [ ] DatetimeLoadingSQLProviderFactory
   - [ ] DataSourceCheckerFactory
   - [ ] StoragePrivilegeHandlerFactory
   - [ ] RuleDefinitionAlterPreprocessorFactory
   - [ ] SaneQueryResultEngineFactory
   - [ ] RuleDefinitionUpdaterFactory
   - [ ] MetaDataRefresherFactory
   - [ ] StatementMemoryStrictlyFetchSizeSetterFactory
   - [ ] ReplicaLoadBalanceAlgorithmFactory
   - [ ] DatetimeServiceFactory
   - [ ] RowBasedJobLockFactory
   - [ ] RuleBasedJobLockFactory
   - [ ] KeyGenerateAlgorithmFactory
   - [ ] RuleAlteredJobConfigurationPreparerFactory
   - [ ] TrafficLoadBalanceAlgorithmFactory
   - [ ] ResultProcessEngineFactory
   - [ ] SQLRouterFactory
   - [ ] SQLCheckerFactory
   - [ ] RuleBasedSchemaMetaDataBuilderFactory
   - [ ] ExecutionPrepareDecoratorFactory
   - [ ] SQLRewriteContextDecoratorFactory
   - [ ] DataNodeBuilderFactory
   - [ ] SchemaRuleBuilderFactory
   - [ ] GlobalRuleBuilderFactory
   - [ ] DefaultGlobalRuleConfigurationBuilderFactory
   - [ ] DefaultSchemaRuleConfigurationBuilderFactory
   
   The SPI factories need to add more test cases are:
   
   - [ ] XAConnectionWrapperFactoryTest


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] terrymanu closed issue #17537: Add test cases for SPI factories

Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #17537: Add test cases for SPI factories
URL: https://github.com/apache/shardingsphere/issues/17537


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] terrymanu commented on issue #17537: Add test cases for SPI factories

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #17537:
URL: https://github.com/apache/shardingsphere/issues/17537#issuecomment-1186807560

   Great! All tasks are completed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org