You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/10 07:20:50 UTC

[GitHub] [dolphinscheduler] liubo1990 opened a new pull request, #10401: modify faq.md

liubo1990 opened a new pull request, #10401:
URL: https://github.com/apache/dolphinscheduler/pull/10401

   <!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
   
   
   ## Purpose of the pull request
   Fix the issue mentioned in issue [10384](https://github.com/apache/dolphinscheduler/issues/10384#issue-1265753728)
   <!--(For example: This pull request adds checkstyle plugin).-->
   
   ## Brief change log
   Added the steps of how to set the alarm mailbox in faq.md
   <!--*(for example:)*
     - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
     - *Added dolphinscheduler-dao tests for end-to-end.*
     - *Added CronUtilsTest to verify the change.*
     - *Manually verified the change by testing locally.* -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10401: [Doc] Add how to set the alarm mailbox in faq

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10401:
URL: https://github.com/apache/dolphinscheduler/pull/10401#issuecomment-1158862050

   > LGTM. Do you have any better suggestions? @zhongjiajie
   
   nop, merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10401: [Fix][Doc]Add the steps of how to set the alarm mailbox in faq.md

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10401:
URL: https://github.com/apache/dolphinscheduler/pull/10401#discussion_r894241260


##########
docs/docs/zh/faq.md:
##########
@@ -24,7 +24,10 @@ A：DolphinScheduler 由 5 个服务组成，MasterServer、WorkerServer、ApiSe
 
 ## Q：系统支持哪些邮箱？
 
-A：支持绝大多数邮箱，qq、163、126、139、outlook、aliyun 等皆支持。支持 **TLS 和 SSL** 协议，可以在 alert.properties 中选择性配置
+A：支持绝大多数邮箱，qq、163、126、139、outlook、aliyun 等皆支持。支持 **TLS 和 SSL** 协议，可以在dolphinscheduler的ui中进行配置：
+![faq](../../img/faq_alter1.png)

Review Comment:
   I think we should put all this into ```docs/docs/en/guide/alert/email.md``` like any other alert channel. And refer the link to the faq.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] liubo1990 commented on a diff in pull request #10401: [Fix][Doc]Add the steps of how to set the alarm mailbox in faq.md

Posted by GitBox <gi...@apache.org>.
liubo1990 commented on code in PR #10401:
URL: https://github.com/apache/dolphinscheduler/pull/10401#discussion_r894255171


##########
docs/docs/zh/faq.md:
##########
@@ -24,7 +24,10 @@ A：DolphinScheduler 由 5 个服务组成，MasterServer、WorkerServer、ApiSe
 
 ## Q：系统支持哪些邮箱？
 
-A：支持绝大多数邮箱，qq、163、126、139、outlook、aliyun 等皆支持。支持 **TLS 和 SSL** 协议，可以在 alert.properties 中选择性配置
+A：支持绝大多数邮箱，qq、163、126、139、outlook、aliyun 等皆支持。支持 **TLS 和 SSL** 协议，可以在dolphinscheduler的ui中进行配置：

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] liubo1990 commented on a diff in pull request #10401: [Fix][Doc]Add the steps of how to set the alarm mailbox in faq.md

Posted by GitBox <gi...@apache.org>.
liubo1990 commented on code in PR #10401:
URL: https://github.com/apache/dolphinscheduler/pull/10401#discussion_r894273405


##########
docs/docs/zh/faq.md:
##########
@@ -24,7 +24,10 @@ A：DolphinScheduler 由 5 个服务组成，MasterServer、WorkerServer、ApiSe
 
 ## Q：系统支持哪些邮箱？
 
-A：支持绝大多数邮箱，qq、163、126、139、outlook、aliyun 等皆支持。支持 **TLS 和 SSL** 协议，可以在 alert.properties 中选择性配置
+A：支持绝大多数邮箱，qq、163、126、139、outlook、aliyun 等皆支持。支持 **TLS 和 SSL** 协议，可以在dolphinscheduler的ui中进行配置：
+![faq](../../img/faq_alter1.png)

Review Comment:
   It is a good idea



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10401: [Fix][Doc]Add the steps of how to set the alarm mailbox in faq.md

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10401:
URL: https://github.com/apache/dolphinscheduler/pull/10401#discussion_r894238776


##########
docs/docs/zh/faq.md:
##########
@@ -24,7 +24,10 @@ A：DolphinScheduler 由 5 个服务组成，MasterServer、WorkerServer、ApiSe
 
 ## Q：系统支持哪些邮箱？
 
-A：支持绝大多数邮箱，qq、163、126、139、outlook、aliyun 等皆支持。支持 **TLS 和 SSL** 协议，可以在 alert.properties 中选择性配置
+A：支持绝大多数邮箱，qq、163、126、139、outlook、aliyun 等皆支持。支持 **TLS 和 SSL** 协议，可以在dolphinscheduler的ui中进行配置：

Review Comment:
   Please also modify the english docs.
   ```docs/docs/en/faq.md```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie merged pull request #10401: [Doc] Add how to set the alarm mailbox in faq

Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #10401:
URL: https://github.com/apache/dolphinscheduler/pull/10401


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] liubo1990 commented on pull request #10401: [Fix][Doc]Add the steps of how to set the alarm mailbox in faq.md

Posted by GitBox <gi...@apache.org>.
liubo1990 commented on PR #10401:
URL: https://github.com/apache/dolphinscheduler/pull/10401#issuecomment-1155891078

   > img check failed https://github.com/apache/dolphinscheduler/runs/6879865864?check_suite_focus=true, please remove the img '/img/faq_alter2.png', '/img/faq_alter1.png', '/img/faq_alter3.png'
   The corresponding image has been removed, it should be fine now
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10401: [Fix][Doc]Add the steps of how to set the alarm mailbox in faq.md

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10401:
URL: https://github.com/apache/dolphinscheduler/pull/10401#issuecomment-1155093771

   img check failed https://github.com/apache/dolphinscheduler/runs/6879865864?check_suite_focus=true, please remove the img '/img/faq_alter2.png', '/img/faq_alter1.png', '/img/faq_alter3.png'


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10401: [Fix][Doc]Add the steps of how to set the alarm mailbox in faq.md

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10401:
URL: https://github.com/apache/dolphinscheduler/pull/10401#issuecomment-1153434091

   > Please use the English language and latest version of DolphinScheduler for the screenshot
   
   Please only use English version screenshot in both English and Chinese version document @liubo1990 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] liubo1990 commented on pull request #10401: [Fix][Doc]Add the steps of how to set the alarm mailbox in faq.md

Posted by GitBox <gi...@apache.org>.
liubo1990 commented on PR #10401:
URL: https://github.com/apache/dolphinscheduler/pull/10401#issuecomment-1154601212

   > > Please use the English language and latest version of DolphinScheduler for the screenshot
   > 
   > Please only use English version screenshot in both English and Chinese version document @liubo1990
   
   @zhongjiajie ，ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10401: [Fix][Doc]Add the steps of how to set the alarm mailbox in faq.md

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10401:
URL: https://github.com/apache/dolphinscheduler/pull/10401#discussion_r896729953


##########
docs/docs/zh/faq.md:
##########
@@ -24,7 +24,10 @@ A：DolphinScheduler 由 5 个服务组成，MasterServer、WorkerServer、ApiSe
 
 ## Q：系统支持哪些邮箱？
 
-A：支持绝大多数邮箱，qq、163、126、139、outlook、aliyun 等皆支持。支持 **TLS 和 SSL** 协议，可以在 alert.properties 中选择性配置
+A：支持绝大多数邮箱，qq、163、126、139、outlook、aliyun 等皆支持。支持 **TLS 和 SSL** 协议，可以在dolphinscheduler的ui中进行配置：
+![faq](../../img/faq_alter1.png)

Review Comment:
   reslove



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] liubo1990 commented on pull request #10401: [Fix][Doc]Add the steps of how to set the alarm mailbox in faq.md

Posted by GitBox <gi...@apache.org>.
liubo1990 commented on PR #10401:
URL: https://github.com/apache/dolphinscheduler/pull/10401#issuecomment-1155892044

   > img check failed https://github.com/apache/dolphinscheduler/runs/6879865864?check_suite_focus=true, please remove the img '/img/faq_alter2.png', '/img/faq_alter1.png', '/img/faq_alter3.png'
   
   The corresponding image has been removed, it should be fine now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org