You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Ryan Baxter (Created) (JIRA)" <ji...@apache.org> on 2011/10/14 20:14:11 UTC

[jira] [Created] (SHINDIG-1641) Remove System.out.println from OAuth2ServiceImpl

Remove System.out.println from OAuth2ServiceImpl
------------------------------------------------

                 Key: SHINDIG-1641
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1641
             Project: Shindig
          Issue Type: Bug
    Affects Versions: 3.0.0
            Reporter: Ryan Baxter
            Priority: Minor


There is a system.out.println in OAuth2ServiceImpl

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (SHINDIG-1641) Remove System.out.println from OAuth2ServiceImpl

Posted by "Ryan Baxter (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan Baxter updated SHINDIG-1641:
---------------------------------

    Attachment: issue-1641.patch
    
> Remove System.out.println from OAuth2ServiceImpl
> ------------------------------------------------
>
>                 Key: SHINDIG-1641
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1641
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Ryan Baxter
>            Priority: Minor
>         Attachments: issue-1641.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> There is a system.out.println in OAuth2ServiceImpl

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SHINDIG-1641) Remove System.out.println from OAuth2ServiceImpl

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127768#comment-13127768 ] 

jiraposter@reviews.apache.org commented on SHINDIG-1641:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2387/
-----------------------------------------------------------

Review request for shindig and Eric Woods.


Summary
-------

There is a system.out.println in OAuth2ServiceImpl


This addresses bug SHINDIG-1641.
    https://issues.apache.org/jira/browse/SHINDIG-1641


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/OAuth2ServiceImpl.java 1183394 

Diff: https://reviews.apache.org/r/2387/diff


Testing
-------

Ran build


Thanks,

Ryan


                
> Remove System.out.println from OAuth2ServiceImpl
> ------------------------------------------------
>
>                 Key: SHINDIG-1641
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1641
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Ryan Baxter
>            Priority: Minor
>         Attachments: issue-1641.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> There is a system.out.println in OAuth2ServiceImpl

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SHINDIG-1641) Remove System.out.println from OAuth2ServiceImpl

Posted by "Paul Lindner (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127817#comment-13127817 ] 

Paul Lindner commented on SHINDIG-1641:
---------------------------------------

really no need to do all this heavyweight stuff for such a simple patch.

                
> Remove System.out.println from OAuth2ServiceImpl
> ------------------------------------------------
>
>                 Key: SHINDIG-1641
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1641
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Ryan Baxter
>            Priority: Minor
>         Attachments: issue-1641.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> There is a system.out.println in OAuth2ServiceImpl

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SHINDIG-1641) Remove System.out.println from OAuth2ServiceImpl

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127908#comment-13127908 ] 

jiraposter@reviews.apache.org commented on SHINDIG-1641:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2387/#review2604
-----------------------------------------------------------

Ship it!


+1

- Henry


On 2011-10-14 18:40:11, Ryan Baxter wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2387/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-14 18:40:11)
bq.  
bq.  
bq.  Review request for shindig and Eric Woods.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  There is a system.out.println in OAuth2ServiceImpl
bq.  
bq.  
bq.  This addresses bug SHINDIG-1641.
bq.      https://issues.apache.org/jira/browse/SHINDIG-1641
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/OAuth2ServiceImpl.java 1183394 
bq.  
bq.  Diff: https://reviews.apache.org/r/2387/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran build
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ryan
bq.  
bq.


                
> Remove System.out.println from OAuth2ServiceImpl
> ------------------------------------------------
>
>                 Key: SHINDIG-1641
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1641
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Ryan Baxter
>            Priority: Minor
>         Attachments: issue-1641.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> There is a system.out.println in OAuth2ServiceImpl

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SHINDIG-1641) Remove System.out.println from OAuth2ServiceImpl

Posted by "Ryan Baxter (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127823#comment-13127823 ] 

Ryan Baxter commented on SHINDIG-1641:
--------------------------------------

yup thought about just committing it but was more doing it for Eric's awareness.  Thanks.
                
> Remove System.out.println from OAuth2ServiceImpl
> ------------------------------------------------
>
>                 Key: SHINDIG-1641
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1641
>             Project: Shindig
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Ryan Baxter
>            Priority: Minor
>         Attachments: issue-1641.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> There is a system.out.println in OAuth2ServiceImpl

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira