Re: cvs commit: modperl-2.0/ModPerl-Registry/t/cgi-bin content_type.pl

[Stas Bekman <st...@stason.org>]

stas@apache.org wrote:
> stas        2003/02/06 18:49:01
> 
>   Modified:    src/modules/perl modperl_filter.c
>                ModPerl-Registry/t basic.t
>   Added:       ModPerl-Registry/t/cgi-bin content_type.pl
>   Log:
>   if the handler sets the content-type, don't parse the headers because
>   there most likely there will be none

This is a delicate issue because it's new to 2.0. In 1.0 handlers had to say 
$r->send_http_header() in order to avoid the headers scanning (assuming that 
they were configured to have the scanning). In 2.0 the handlers don't send the 
header by themselves.

So this change has the following implications:

if the handler sets $r->content_type(), the scanning of headers won't be 
performed.

Speak up if you think there could be issues with this solution. And if so, 
suggest an alternative logic.

>   Index: modperl_filter.c
>   ===================================================================
>   RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_filter.c,v
>   retrieving revision 1.50
>   retrieving revision 1.51
>   diff -u -r1.50 -r1.51
>   --- modperl_filter.c	7 Feb 2003 02:30:52 -0000	1.50
>   +++ modperl_filter.c	7 Feb 2003 02:49:01 -0000	1.51
>   @@ -10,13 +10,13 @@
>        apr_bucket *bucket;
>        const char *work_buf = buf;
>        
>   -    if (wb->header_parse) {
>   +    if (wb->header_parse && !wb->r->content_type) {

[...]
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org