[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #11418: feat: Explore time picker enhancement

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #11418:
URL: https://github.com/apache/incubator-superset/pull/11418#discussion_r544763767



##########
File path: superset/charts/api.py
##########
@@ -997,3 +1001,56 @@ def import_(self) -> Response:
         except Exception as exc:  # pylint: disable=broad-except
             logger.exception("Import chart failed")
             return self.response_500(message=str(exc))
+
+    @expose("/time_range/", methods=["GET"])

Review comment:
       Thanks @zhaoyongjie this PR is great! Just curious when do we need call this new API `/time_range/`? i assume most of cases we only call the internal function?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org