You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/09 15:14:17 UTC

[GitHub] [kafka] ijuma commented on a change in pull request #9715: Upstream ApisUtils from kip-500

ijuma commented on a change in pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#discussion_r539390329



##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -98,6 +97,7 @@ import scala.annotation.nowarn
  * Logic to handle the various Kafka requests
  */
 class KafkaApis(val requestChannel: RequestChannel,
+                val apisUtils: ApisUtils,

Review comment:
       Is this an improvement? I am not sure. A couple of things:
   1. The `Utils` suffix looks odd both in a trait as well as a class that is instantiated.
   2. Using delegation allows for better separation of concerns than inheritance.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org