You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/11/02 08:32:49 UTC
[GitHub] [apisix-ingress-controller] zou8944 opened a new pull request, #1428: fix: cluster.metricsCollector invoked before assign when MountWebhooks
zou8944 opened a new pull request, #1428:
URL: https://github.com/apache/apisix-ingress-controller/pull/1428
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1428: fix: cluster.metricsCollector invoked before assign when MountWebhooks
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1428:
URL: https://github.com/apache/apisix-ingress-controller/pull/1428#issuecomment-1299966871
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1428?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1428](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1428?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50b87d3) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/eff8ce1b70513980d96f26e7ac526b6180e14856?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eff8ce1) will **decrease** coverage by `0.49%`.
> The diff coverage is `36.90%`.
> :exclamation: Current head 50b87d3 differs from pull request most recent head d3e84ca. Consider uploading reports for the commit d3e84ca to get more accurate results
```diff
@@ Coverage Diff @@
## master #1428 +/- ##
==========================================
- Coverage 40.89% 40.39% -0.50%
==========================================
Files 78 82 +4
Lines 7231 7446 +215
==========================================
+ Hits 2957 3008 +51
- Misses 3933 4090 +157
- Partials 341 348 +7
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1428?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1428/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | `61.36% <ø> (ø)` | |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1428/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `56.79% <0.00%> (-6.23%)` | :arrow_down: |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1428/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `66.34% <ø> (ø)` | |
| [pkg/providers/ingress/translation/annotations.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1428/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9pbmdyZXNzL3RyYW5zbGF0aW9uL2Fubm90YXRpb25zLmdv) | `58.82% <ø> (ø)` | |
| [pkg/providers/ingress/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1428/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9pbmdyZXNzL3RyYW5zbGF0aW9uL3RyYW5zbGF0b3IuZ28=) | `0.00% <0.00%> (ø)` | |
| [...providers/k8s/configmap/translation/translation.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1428/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9rOHMvY29uZmlnbWFwL3RyYW5zbGF0aW9uL3RyYW5zbGF0aW9uLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/apisix/plugin\_metadata.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1428/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW5fbWV0YWRhdGEuZ28=) | `4.39% <4.39%> (ø)` | |
| [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1428/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | `41.20% <9.09%> (-2.07%)` | :arrow_down: |
| [pkg/providers/utils/manifest.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1428/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy91dGlscy9tYW5pZmVzdC5nbw==) | `42.79% <54.16%> (-2.83%)` | :arrow_down: |
| [pkg/providers/k8s/configmap/translation/parse.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1428/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9rOHMvY29uZmlnbWFwL3RyYW5zbGF0aW9uL3BhcnNlLmdv) | `55.55% <55.55%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1428/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] zou8944 commented on pull request #1428: fix: cluster.metricsCollector invoked before assign when MountWebhooks
Posted by GitBox <gi...@apache.org>.
zou8944 commented on PR #1428:
URL: https://github.com/apache/apisix-ingress-controller/pull/1428#issuecomment-1299818638
the issue: https://github.com/apache/apisix-ingress-controller/issues/1427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1428: fix: cluster.metricsCollector invoked before assign when MountWebhooks
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1428:
URL: https://github.com/apache/apisix-ingress-controller/pull/1428#issuecomment-1301835796
Please check the lint error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1428: fix: cluster.metricsCollector invoked before assign when MountWebhooks
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged PR #1428:
URL: https://github.com/apache/apisix-ingress-controller/pull/1428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org