[GitHub] [flink-table-store] liyubin117 commented on a diff in pull request #89: [FLINK-27172] Support bulk based format provided by Flink

[GitBox <gi...@apache.org>]

liyubin117 commented on code in PR #89:
URL: https://github.com/apache/flink-table-store/pull/89#discussion_r847343312


##########
flink-table-store-dist/pom.xml:
##########
@@ -118,8 +112,6 @@ under the License.
                                     <include>org.apache.flink:flink-table-store-core</include>
                                     <include>org.apache.flink:flink-table-store-format</include>
                                     <include>org.apache.flink:flink-table-store-kafka</include>
-                                    <include>org.apache.flink:flink-connector-base</include>

Review Comment:
   exception as follow:
   ```
   Could not find any factories that implement 'org.apache.flink.table.store.shaded.org.apache.flink.connector.file.table.factories.BulkReaderFormatFactory' in the classpath.
       at org.apache.flink.table.factories.FactoryUtil.discoverFactory(FactoryUtil.java:526) 
   ```
   the detailed reason is that flink-table-store use `FileFormatImpl` to discover formats implementing `BulkReaderFormatFactory` provided by Flink, but the name of interface has been shaded into different one, caused the exception as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org